Summary: | www/youtube_dl: distfile fetch fails over IPv6-only network | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Evgenii Khramtsov <2khramtsov> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-multimedia (Nobody) <multimedia> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | 2khramtsov, arrowd, diizzy | ||||||
Priority: | --- | Flags: | 2khramtsov:
maintainer-feedback-
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Evgenii Khramtsov
2021-06-06 00:15:37 UTC
Created attachment 225989 [details] patch Patch attached with commit message ("git am"). I used upstream provided tarball instead, as in https://cgit.freebsd.org/ports/commit/?id=29e87cd021e8fb0ef77948bc5e049f1283e2a493 Stick do DISTVERSION everywhere rather than mixing PORT and DISTVERSION and why not keep main site as fallback? Created attachment 226032 [details] v2 > why not keep main site as fallback? GH likely has better bandwidth and uptime; I don't see the need to keep yt-dl.org. Hostmaster ignores mail, so if the website is down, it would likely remain down longer than any possible GH outage. I think it would not hurt to have yt-dl.org as a fallback, attached v2 after your review. A better solution would be to mirror the distfile at distcache.FreeBSD.org, which has AAAA RR without the need of DNS64/NAT64. I think only a committer can do that. > Stick do DISTVERSION everywhere rather than mixing PORT and DISTVERSION Right, I wanted to minimize the amount of change, so a maintainer is more likely to approve the patch. V2 changes more as you suggested. Thanks for review. yt-dl.org link stil uses PORTVERSION, as a workaround for those who don't want to fetch it manually for now at least might be www/yt-dlp which is a compatible fork (uses github.com) (In reply to Daniel Engberg from comment #4) Well, seems like I wasn't paying much attention and just copied it as-is... I was distracted with something else yesterday; this is trivial enough to change if someone commits it, sorry for that. > as a workaround for those who don't want to fetch it manually /etc/hosts entry (uses nat64.net): 2a00:1098:2b::95.143.172.170 yt-dl.org Maintainer timeout. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1138b7cb7a81f7a0348788a7aca8ccc85aaf1367 commit 1138b7cb7a81f7a0348788a7aca8ccc85aaf1367 Author: Evgeniy Khramtsov <evgeniy@khramtsov.org> AuthorDate: 2021-07-25 10:44:21 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2021-07-25 10:46:09 +0000 www/youtube_dl: Add Github to MASTER_SITES. The original site is unreachable from IPv6-only networks. While there, switch to using DISTVERSION. PR: 256432 Tested by: arrowd Approved by: multimedia (maintainer timeout) www/youtube_dl/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) Pushed in, thanks. |