Bug 256529

Summary: www/searx: Update to 1.0.0
Product: Ports & Packages Reporter: Zane C. Bowers-Hadley <vvelox>
Component: Individual Port(s)Assignee: Rainer Hurling <rhurlin>
Status: Closed FIXED    
Severity: Affects Only Me CC: loic.blot, rhurlin
Priority: --- Flags: loic.blot: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://asciimoo.github.io/searx/
Bug Depends on: 256527    
Bug Blocks:    
Description Flags
git dff
git diff
git diff none

Comment 1 Zane C. Bowers-Hadley 2021-06-10 07:24:41 UTC
Created attachment 225693 [details]
git dff
Comment 2 loic.blot 2021-06-10 07:45:41 UTC
as i'm not really on FreeBSD nowadays, do you want to take the ownership ?
Comment 3 Zane C. Bowers-Hadley 2021-06-10 07:46:18 UTC
Sure. I will happily take this over. :)
Comment 4 Rainer Hurling freebsd_committer 2021-06-10 11:56:24 UTC
(In reply to Zane C. Bowers-Hadley from comment #3)

Hi Zane,

Then I will add you as a new maintainer in the Makefile?

I am in the preparation for some Poudriere builds and tests ...
Comment 5 Rainer Hurling freebsd_committer 2021-06-10 12:09:51 UTC
AFAICS, there is no port www/py-httpx-socks, listed as a dependency in your patch?
Comment 6 Rainer Hurling freebsd_committer 2021-06-10 12:12:23 UTC
(In reply to Rainer Hurling from comment #5)

Oops, I just recognized, that there is a PR 256527 with a patch for a new port www/py-httpx-socks. I
Comment 7 Zane C. Bowers-Hadley 2021-06-10 13:00:35 UTC
Created attachment 225700 [details]
git diff

bump min python version from 3.6 to 3.7
Comment 8 Rainer Hurling freebsd_committer 2021-06-10 13:22:41 UTC
Thanks for the updated patch.

It seems to build and install fine on Poudriere ;)

Did you test run searx with apache and/or nginx? Does it work for you?

(on my dev box I am not able to test a running searx installation ATM).
Comment 9 Zane C. Bowers-Hadley 2021-06-10 13:30:47 UTC
Aye! Sounds good.
Comment 10 Zane C. Bowers-Hadley 2021-06-10 13:31:39 UTC
As far as testing goes, been using it with Apache here. Updated my install from the previous version to this one and it has been running great.
Comment 11 Rainer Hurling freebsd_committer 2021-06-10 13:41:04 UTC
(In reply to Zane C. Bowers-Hadley from comment #10)

Nice to hear :)

One more point: 'make stage-qa' complains about

Warning: Possible REINPLACE_CMD issues:
- REINPLACE_CMD ran, but did not modify file contents: /poudriere/ports/default/www/searx/work/.PLIST.pymodtmp

Obviously, the first lines of the post-install target are not needed in this version?

	# workaround for https://github.com/asciimoo/searx/issues/1208
	@${REINPLACE_CMD} -e 's|.*/tests/.*||' ${_PYTHONPKGLIST}

I would suggest that we remove these lines.
Comment 12 Zane C. Bowers-Hadley 2021-06-13 10:22:47 UTC
Created attachment 225765 [details]
git diff

Tested with those removed and it looks good.
Comment 13 commit-hook freebsd_committer 2021-06-13 13:52:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=182121fa658239fb8f2f74b29e0df89a2b15fe8b

commit 182121fa658239fb8f2f74b29e0df89a2b15fe8b
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2021-06-13 13:43:27 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-06-13 13:51:27 +0000

    www/searx: Update to 1.0.0

    - Change maintainer
    - Needs Python >= 3.7 because of www/py-httpx-socks dependency

    Changelog: https://github.com/searx/searx/releases/tag/1.0.0

    PR:             256529
    Reported by:    Zane C. Bowers-Hadley <vvelox@vvelox.net> (new maintainer)

 www/searx/Makefile | 19 ++++++++++++-------
 www/searx/distinfo |  6 +++---
 2 files changed, 15 insertions(+), 10 deletions(-)
Comment 14 Rainer Hurling freebsd_committer 2021-06-13 13:54:34 UTC
Committed, thanks :)