Bug 256739

Summary: security/dehydrated: hook script interpretion error when ZSH=on and update to 0.7.1
Product: Ports & Packages Reporter: takefu
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (meta)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
dehydrated-0.7.0.patch
none
dehydrated-0.7.1.patch takefu: maintainer-approval+

Description takefu 2021-06-21 01:39:18 UTC
Created attachment 225958 [details]
dehydrated-0.7.0.patch

If the variable to shift is undefined, the following message will be issued and it will be noisy.

/usr/local/etc/dehydrated/hook.sh:shift:217: shift count must be <= $#
Comment 1 takefu 2022-11-01 07:43:24 UTC
Created attachment 237779 [details]
dehydrated-0.7.1.patch

Update to 0.7.1
https://github.com/dehydrated-io/dehydrated/releases/tag/v0.7.1

fix: zsh when enabled hook.sh interpretation problem

PORTLINT(1) PORTCLIPPY(1) compliant.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2022-11-02 01:17:03 UTC
Two points:
- Commit it and send us patch formatted by `git format-patch` next.
` Have you upstreamed the hook script fix?
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-02 01:36:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28355fb7b88bbf4071772bc841946f80c55cbe0e

commit 28355fb7b88bbf4071772bc841946f80c55cbe0e
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2022-11-02 01:30:58 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-11-02 01:30:58 +0000

    security/dehydrated: Update to 0.7.1

    - Update WWW as now upstream has a new site
    - Update pkg-descr with new upstream description

    Changes:        https://github.com/dehydrated-io/dehydrated/releases/tag/v0.7.1
    PR:             256739 266713

 security/dehydrated/Makefile  | 21 +++++++++------------
 security/dehydrated/distinfo  |  6 +++---
 security/dehydrated/pkg-descr |  4 ++--
 3 files changed, 14 insertions(+), 17 deletions(-)
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2022-11-02 01:37:59 UTC
Committed except hook script fix. I would like an upstream review for that.
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2023-02-27 01:58:45 UTC
No feedback from reporter, closing.