Bug 256766

Summary: misc/mc: Unset option EXTATTR by default
Product: Ports & Packages Reporter: Michael Osipov <michael.osipov>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Only Me CC: michael.osipov
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
Version: Latest   
Hardware: Any   
OS: Any   

Description Michael Osipov 2021-06-22 08:25:39 UTC
The option says "Ext2fs extended attributes support".
Very little need this out of the box, but need to pull yet another port into the system. For those who need this can enable with make config, but 99% don't need it.

Please disable this by default to reduce dependencies.
Comment 1 Alexey Dokuchaev freebsd_committer 2021-06-22 08:58:20 UTC
> The option says "Ext2fs extended attributes support".
Yeah, the description is a bit misleading, it's not limited exclusively to ext2fs, but can also manage UFS-specific flags like append-only, etc.

> Please disable this by default to reduce dependencies.
Given that there are other issues* with it, I guess it makes sense to disable it by default.

*) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249284#c17
Comment 2 Michael Osipov 2021-06-22 09:23:29 UTC
(In reply to Alexey Dokuchaev from comment #1)

Hah, I have exactly the same problem as Oleg, but did not notice because I am on thick jails. Yet another reason to disable it.
Comment 3 commit-hook freebsd_committer 2021-06-24 08:04:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4eb82883317e97c3851e041c415fca854bf062fc

commit 4eb82883317e97c3851e041c415fca854bf062fc
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-06-24 08:02:58 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-06-24 08:03:15 +0000

    misc/mc: the port had been improved (+)

    - By popular demand, disable EXTATTR option by default: the benefits
      it provides are outweighed by having to pull `sysutils/e2fsprogs'
      port as dependency and various troubles people are having with it.
      While here, adjust the description as it was is a bit misleading:
      it is not limited exclusively to ext2fs, but can also manage UFS-
      specific flags like append-only, etc. [1]

    - Fix ZIP/UNZIP program detection and add missing dependency on the
      `archivers/zip' as FreeBSD does not provide native zip(1) program.
      This bug had been present since late 2014: when fixing PR 193766,
      an incomplete patch had been committed; it went unnoticed because
      apparently users rarely create ZIP archives, and extraction worked
      because `archivers/unzip' is very commonly installed package [2]

    PR:     249284, 256766 [1]
            256546, 193766 [2]

 misc/mc/Makefile | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)