Bug 256799

Summary: devel/py-btest: Update to 0.68
Product: Ports & Packages Reporter: Craig Leres <leres>
Component: Individual Port(s)Assignee: Craig Leres <leres>
Status: Closed FIXED    
Severity: Affects Only Me CC: mshirk
Priority: --- Flags: mshirk: maintainer-feedback+
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch mshirk: maintainer-approval+

Description Craig Leres freebsd_committer freebsd_triage 2021-06-24 00:52:26 UTC
Update to 0.68 and switch to github.

I'm working zkg (the Zeek package manager) which requires btest and would prefer to use the ports version instead of than the 0.68 that is bundled with zeek.

Changes since 0.67:
 - Preserve CRLF line-terminators in test files

Will commit with maintainer approval.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2021-06-24 00:53:20 UTC
Created attachment 226020 [details]
patch
Comment 2 Shirkdog 2021-06-24 01:39:10 UTC
Looks good to me. zkg is now at v2.10.0, so I will get that submitted and updated.
Comment 3 Craig Leres freebsd_committer freebsd_triage 2021-06-24 01:53:50 UTC
Hah, I didn't even notice there was a py-zkg package!

If the patch looks ok, could you please click on "Details" for the attachment, change maintainer-approval to '+' and submit?

Also, once you submit a PR for the pkg-zkg update, feel free to ping me and/or assign it to me. And again, if you give maintainer-approval I can commit that change as well.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-24 03:17:33 UTC
^Triage: Modulo the version update, unless its also a bigfix version, I'd consider this a case of:

Approved by: portmgr (blanket: ports compliance, unbundle dependencies)

Note also when settings flags for approval, set the email of the person you an ack from, as this value enables notification emails, and also allows target of the flag to set the flags value
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-06-25 21:04:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5cc231cdf26434526aa5886ecf643382ed52e443

commit 5cc231cdf26434526aa5886ecf643382ed52e443
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2021-06-25 21:01:58 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2021-06-25 21:01:58 +0000

    devel/py-btest: Update to 0.68 and switch to github

    Changes since 0.67:

     - Preserve CRLF line-terminators in test files

    PR:             256799
    Approved by:    mshirk@daemon-security.com (maintainer)

 devel/py-btest/Makefile  |  7 +++++--
 devel/py-btest/distinfo  |  6 +++---
 devel/py-btest/pkg-descr | 16 ++++++++--------
 3 files changed, 16 insertions(+), 13 deletions(-)
Comment 6 Craig Leres freebsd_committer freebsd_triage 2021-06-25 21:07:57 UTC
@koobs: thanks for the hint about maintainer-approval, I either never noticed it worked that way or it's changed.

Shirkdog: appreciate the quick approval.