Bug 256818

Summary: multimedia/vdr-plugin-xineliboutput: fix build
Product: Ports & Packages Reporter: Stefan Ehmann <shoesoft>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Only Me CC: sterum77
Priority: --- Keywords: needs-qa, regression
Version: LatestFlags: koobs: merge-quarterly?
Hardware: Any   
OS: Any   
URL: https://sourceforge.net/p/xineliboutput/git/ci/7409b309432f21d871b9c37600e9c3c0632628ab/
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253304
Attachments:
Description Flags
patch to fix build
none
patch-configure
none
patch-c++11
none
vdr-plugin-xineliboutput.diff koobs: maintainer-approval+

Description Stefan Ehmann 2021-06-24 22:28:59 UTC
Created attachment 226043 [details]
patch to fix build

After recent changes (probably libglvnd related) the port fails to build with:
ld: error: undefined symbol: glXQueryVersion

I've created a patch to include the upstream fix
https://sourceforge.net/p/xineliboutput/git/ci/7409b309432f21d871b9c37600e9c3c0632628ab/

See PR 253304 for discussion on the state of vdr* ports. I still don't have time to do a proper update.
Comment 1 Stefan Rumetshofer 2021-08-31 07:06:59 UTC
Created attachment 227565 [details]
patch-configure
Comment 2 Stefan Rumetshofer 2021-08-31 07:07:36 UTC
Created attachment 227566 [details]
patch-c++11
Comment 3 Stefan Rumetshofer 2021-08-31 07:09:47 UTC
I put your patch and the existing one for the configure script together.
And i also created a patch which unbreaks the build with c++11.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-31 07:14:58 UTC
Thank you for the report and patch Stefan. 

If you can manage and have time, a single patch against the port would be great. 

Patches/changes against upstream sources can be produced automatically using the 'make makepatch' target in the port dir, after creating $file $file.orig pairs and making the changes in $file
Comment 5 Stefan Rumetshofer 2021-08-31 07:35:52 UTC
Created attachment 227567 [details]
vdr-plugin-xineliboutput.diff

Here is the diff against the whole port
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-01 00:56:53 UTC
(In reply to Stefan Rumetshofer from comment #5)

Thanks Stefan!
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-01 00:57:58 UTC
Comment on attachment 227567 [details]
vdr-plugin-xineliboutput.diff

Approved by: portmgr (blanket: unmaintained port)
MFH: Yes