Summary: | devel/py-zipp: Build issue when devel/py-setuptools_scm has its TOML option disabled | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Philipp Engel <kidon> |
Component: | Individual Port(s) | Assignee: | Danilo G. Baio <dbaio> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | dbaio, python |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(swills) dbaio: merge-quarterly+ |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Philipp Engel
2021-06-28 13:06:29 UTC
@Philipp Was this a regression against a previous version? If so, what was the last version that successfully built? The last update was October 2020 in ports r553729 zipp declares toml (via setuptools_scm[toml]) as a setup_requires [1][2], which is not included as a BUILD_DEPENDS in the port [1] setup.cfg: setup_requires = setuptools_scm[toml] >= 3.4.1 [2] https://github.com/jaraco/zipp/blob/main/setup.cfg#L23 (In reply to Kubilay Kocak from comment #2) I missed this in the review, but Kai (via IRC) notes that 'toml' should be satisfied via the TOML option in setuptools_scm, which is enabled by default, so this is likely a case of that option being disabled. Is that the case Philipp? Nevertheless, ports (like this one) must depend explicitly on their dependencies optional dependencies (transitively), and not rely on their presence (which, is... optional). Kubilay: Thank you. As you said, the disabled TOML option in devel/py-setuptools_scm caused the issue. (In reply to Philipp Engel from comment #4) Thank you for the confirmation Philipp. We'll take care of the issue in the port. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8c08a2edf09b17f5fd1da63dc4c25f7eec8620b7 commit 8c08a2edf09b17f5fd1da63dc4c25f7eec8620b7 Author: Danilo G. Baio <dbaio@FreeBSD.org> AuthorDate: 2021-08-20 11:45:04 +0000 Commit: Danilo G. Baio <dbaio@FreeBSD.org> CommitDate: 2021-08-20 11:45:04 +0000 devel/py-zipp: Add missing toml build dependency A build issue occurs when devel/py-setuptools_scm has its TOML option disabled. PR: 256872 Reported by: Philipp Engel <kidon@posteo.de> Approved by: portmgr (blanket) MFH: 2021Q3 devel/py-zipp/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) A commit in branch 2021Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=99e517d0de483a7649a3361355d2e4aad16a23e5 commit 99e517d0de483a7649a3361355d2e4aad16a23e5 Author: Danilo G. Baio <dbaio@FreeBSD.org> AuthorDate: 2021-08-20 11:45:04 +0000 Commit: Danilo G. Baio <dbaio@FreeBSD.org> CommitDate: 2021-08-20 11:53:01 +0000 devel/py-zipp: Add missing toml build dependency A build issue occurs when devel/py-setuptools_scm has its TOML option disabled. PR: 256872 Reported by: Philipp Engel <kidon@posteo.de> Approved by: portmgr (blanket) (cherry picked from commit 8c08a2edf09b17f5fd1da63dc4c25f7eec8620b7) devel/py-zipp/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Committed, thanks! |