Bug 256925
| Summary: | [NEW PORT]: devel/py-cymbal: Easily add functionality missing from libclang Python bindings | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Neal Nelson <ports> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Yasuhiro Kimura <yasu> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | ports, python, swills, yasu | ||||||||||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(ports) |
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| URL: | https://github.com/CadQuery/cymbal | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 257131 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 226390 [details]
Git diff of new port.
Update new port to use CHEESESHOP instead of directly using git.
Created attachment 226393 [details]
Git diff of new port.
Add python pseudo-category.
(In reply to Neal Nelson from comment #2) I think this might be the wrong diff Created attachment 226704 [details]
Git diff of new port.
Oops, sorry about that. I have a few ports in the air at the moment, and more to come. Hopefully this is the right diff now.
I see that you've flagged this for maintainer feedback, after I updated the patch. What else do I need to do? @Neal ? = feedback requested / needed + = acknowledged (feedback sent/received) (after your comment 4) Settinng it from ? to + ensures you dont receive continued email reminders to 'ack outstanding requests' Confirmation that the port passes QA (portlint, poudriere at least, package test suite ideally as well), would be great. (In reply to Kubilay Kocak from comment #6) As usual, and as specified in the porter's handbook, I have run the usual tests, portlinted and a poudriere testport. I have no idea what the package test suite is though. Is it documented in the porter's handbook? (In reply to Neal Nelson from comment #7) 'Package test suite' here means the 'upstream test suite' (apologies for not being clear earlier). In this case upstream has them as: tests_require=['unittest2'], test_suite='unittest2.collector' Add TEST_DEPENDS on unittest2 and create a do-test target that: cd ${WRKSRC} && ${PYTHON_CMD} -m unittest2 discover (might need 'tests' dir as final arg Created attachment 229091 [details]
Updated patch file
* Add TEST_DEPENDS, TEST_TARGET and do-test target
* Connect to ports tree
* Pet portlint
* Reformat Makefile with portfmt
* Reformat pkg-descr so lines aren't longer than 80 characters
Comment on attachment 229091 [details]
Updated patch file
Sorry about the delay in doing this myself. Well, I have done it but not submitted the change, but it's the same as yours. One test fails, but I've been hoping for some upstream action on this. This doesn't seem to be coming any time soon, so this is as good as it gets for the time being.
The failing test seems to be for a method that's already been added in the library that's being monkey patched, so poses no problem to functionality.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c5067c3e7ef42ebe1b7ad44cc436371e65d1d913 commit c5067c3e7ef42ebe1b7ad44cc436371e65d1d913 Author: Neal Nelson <ports@nicandneal.net> AuthorDate: 2021-10-28 04:20:43 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2021-10-28 08:40:42 +0000 devel/py-cymbal: Add new port Cymbal makes it easy to add functionality missing from libclang Python bindings The Clang libclang python bindings use ctypes to invoke functions present in libclang dynamic library. In some cases, only a subset of the C functions are available, because the platform or version specific Python bindings omit functions. Cymbal simplfies the process of dynamically adding those methods to Types and Cursors. PR: 256925 devel/Makefile | 1 + devel/py-cymbal/Makefile (new) | 22 ++++++++++++++++++++++ devel/py-cymbal/distinfo (new) | 3 +++ devel/py-cymbal/pkg-descr (new) | 10 ++++++++++ 4 files changed, 36 insertions(+) Committed. Thanks! |
Created attachment 226156 [details] Git diff of new port. This is a simple Python module that will be required by an upcoming update to the currently broken cad/py-cadquery.