Bug 256964

Summary: devel/notcurses: Update to 2.3.8
Product: Ports & Packages Reporter: nick black <nickblack>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Many People CC: danfe, swills
Priority: Normal Flags: nickblack: maintainer-feedback+
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/dankamongmen/notcurses/releases/tag/v2.3.8
Attachments:
Description Flags
notcurses 2.3.6 -> 2.3.8 git diff nickblack: maintainer-approval+

Description nick black 2021-07-04 06:43:11 UTC 
Created attachment 226204 [details]
notcurses 2.3.6 -> 2.3.8 git diff

Update devel/notcurses from 2.3.6 -> 2.3.8.

https://github.com/dankamongmen/notcurses/releases/tag/v2.3.8
https://github.com/dankamongmen/notcurses/releases/tag/v2.3.7

there's a compiler warning in the output on FreeBSD about ignoring the result of a function marked pure; this has been fixed upstream, but it is harmless.
Comment 2 nick black 2021-07-09 02:26:36 UTC 
just putting a friendly ping on this. do there appear to be any problems?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-09 09:17:18 UTC 
@Nick Cursory review of the changeset looks fine, though confirmation of QA (poudriere) of both the failing and non failing freebsd versions may help.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-14 12:18:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88de9d949b0ff38bcbb78f68daa9b8cd9306dd9a

commit 88de9d949b0ff38bcbb78f68daa9b8cd9306dd9a
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-07-14 12:17:38 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-07-14 12:17:45 +0000

    devel/notcurses: update the port to version 2.3.8.

    PR:     256964

 devel/notcurses/Makefile  |  2 +-
 devel/notcurses/distinfo  | 10 +++++-----
 devel/notcurses/pkg-plist |  1 +
 3 files changed, 7 insertions(+), 6 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-07-22 18:07:20 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3d6c439d69f6c1f3ee44f4d548a77a897bec7914

commit 3d6c439d69f6c1f3ee44f4d548a77a897bec7914
Author:     Nick Black <nickblack@linux.com>
AuthorDate: 2021-07-14 12:17:38 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2021-07-22 18:06:00 +0000

    devel/notcurses: update the port to version 2.3.8.

    PR:     256964
    (cherry picked from commit 88de9d949b0ff38bcbb78f68daa9b8cd9306dd9a)

    devel/notcurses: Update to 2.3.11

    PR:             ports/257319
    MFH:            2021Q3
    (cherry picked from commit 46af59722e9cf78fa9bee6f07b619902eb86c91a)

 devel/notcurses/Makefile  |  2 +-
 devel/notcurses/distinfo  | 10 +++++-----
 devel/notcurses/pkg-plist |  1 +
 3 files changed, 7 insertions(+), 6 deletions(-)