Bug 257117
| Summary: | x11-toolkits/qt5-gui: add libmtdev dependency, links to libX11 regardless if X11 option is set | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Philipp Ost <bsd> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | adridg | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(kde) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7be3eabb1a7c0e8c300fb66b1a923ab1394b529a commit 7be3eabb1a7c0e8c300fb66b1a923ab1394b529a Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2021-09-05 11:59:11 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2021-09-05 12:11:52 +0000 x11-toolkits/qt5-gui: add missing dependency devel/libmtdev is always a dependency, but wasn't listed as such. PR: 257117 Obtained from: Philipp Ost x11-toolkits/qt5-gui/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) For the X11=OFF case this affects a lot more of the port (e.g. I expect turning off Qt option XCB is needed). There is a branch with possibly-relevant changes in KDE-FreeBSD's Area51 repository, but it's missing a champion to push for an X11-less experience. Closing this one as "the main issue is fixed and the other one is a long-term project". |
Created attachment 226375 [details] x11-toolkits/qt5-gui: add devel/libmtdev to LIB_DEPENDS stage-qa complains that /usr/local/lib/qt5/plugins/generic/libqevdevtouchplugin.so is linked to libmtdev.so.1 from devel/libmtdev which is not declared as a dependency. The attached patch fixes that. If X11=off, stage-qa warns about /usr/local/lib/qt5/libQt5XcbQpa.so.5.15.2 being linked to libX11-xcb.so.1 and /usr/local/lib/libX11.so.6. In addition, when X11=off I get a Makefile warning (Using USE_XORG alone is deprecated, please use USES=xorg). Adding USES+=xorg unconditionally does indeed silence that warning, but doesn't that contradict not wanting X11 support? I wouldn't have expected this. The issue came up because I checked if the dependency on libmtdev depends on the X11 option being set.