Bug 257174

Summary: [NEW PORT] audio/vgmtools: Tools for vgm/vgz files
Product: Ports & Packages Reporter: Timothy Beyer <beyert>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: beyert, diizzy, eduardo, fuz
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/vgmrips/vgmtools
Attachments:
Description Flags
audio_vgmtools.shar
none
[PATCH] new audio/vgmtools: DISTVERSION, updated so no raw install line none

Description Timothy Beyer 2021-07-14 06:47:46 UTC
Created attachment 226447 [details]
audio_vgmtools.shar

This provides miscellaneous tools for vgm/vgz/vg7z files, as used by the audio/vgmplay port.  The notable part of this port is that it has the utility vgm_tag, a command line tool to show GD3 tags used in VGM/VGZ/VG7Z files.  It has numerous other very specialized tools which I haven't tried, but may prove useful to others.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-07-17 18:41:07 UTC
Please read "Example 18. Using USE_GITHUB When Upstream Does Not Use Versions" in Porters Handbook

Doesn't upstream include an install section in CMakeLists.txt or why are binaries installed manually? Please also look at https://docs.freebsd.org/en/books/porters-handbook/book/#install-macros
Comment 2 Timothy Beyer 2022-07-20 08:47:13 UTC
(In reply to Daniel Engberg from comment #1)
Hi, thanks for the suggestions.

So far I have made another version that uses DISTVERSION with the g prefix (and I will do that for all non-versioned Github ports going forward as per the Porter's Handbook).

To answer your question about the INSTALL line, in the version from 20210527 that was submitted above, I looked at both CMakeLists and makefile, and both do not contain install commands, so I included a raw INSTALL line.

However, when I updated it to version 20220718 (which surprisingly builds so far with no patches or even changes to pkg-plist), the CMakeLists does now contain an install command, so I will experiment on poudriere with that all in the CMakeLists.txt as the upstream project now does.

Once I confirm with more testing that the newer version is working across amd64 i386 in both 13.1 and 12.3, then I will update the patch here, and will likely remove the INSTALL line, along with some new changes such as the adjustment to the first line not using the $FreeBSD$ tag.
Comment 3 Timothy Beyer 2022-08-01 09:19:30 UTC
Created attachment 235602 [details]
[PATCH] new audio/vgmtools: DISTVERSION, updated so no raw install line

Here's a git format-patch file that updates it to a newer version that has install defined in CMakeLists.txt.  I switched to use DISTVERSION with the g prefix, as specified.

It has been tested in poudriere in various versions (13.1-RELEASE i386, 13.1-RELEASE amd64, 12.3-RELEASE i386, 12.3-RELEASE amd64), and is more compliant with modern ports formatting standards than my previous submission.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-04-29 12:55:55 UTC
Thank you for your submission.

I'll remove the TOOLS variable on commit as it seems to no longer be needed.
I'll also rework WWW: into the make macro WWW as there was recently a change in conventions.  Will proceed with a build test and then commit.

I've also seen that you undefined STRIP.  Why is that the case?  We want our binaries to be stripped generally (unless WITH_DEBUG is set; there is some tooling to unset STRIP in this case).

I'll also remove the "Created by" line.  We have removed them from the entire ports collection.  They'll not come back.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-04-30 18:44:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=42e0402b6db8ec4b7c8a3f4b21ce671eb3eb0ec2

commit 42e0402b6db8ec4b7c8a3f4b21ce671eb3eb0ec2
Author:     Timothy Beyer <beyert_freebsd@fastmail.net>
AuthorDate: 2022-08-01 09:12:06 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-04-30 18:41:41 +0000

    audio/vgmtools: Tools for vgm/vgz files

    The official and always up-to-date tools for all VGM (Video Game
    Music) files. VGM is an audio file format for multiple video game
    platforms, such as Sega Master System, Game Gear, Mega Drive/Genesis,
    MSX, Neo Geo, IBM PC AT (Adlib/SoundBlaster), and has expanded to a
    variety of arcade system boards since its release.

    WWW: https://github.com/vgmrips/vgmtools

    PR:             257174

 audio/Makefile                 |  1 +
 audio/vgmtools/Makefile (new)  | 18 ++++++++++++++++++
 audio/vgmtools/distinfo (new)  |  3 +++
 audio/vgmtools/pkg-descr (new) |  5 +++++
 audio/vgmtools/pkg-plist (new) | 27 +++++++++++++++++++++++++++
 5 files changed, 54 insertions(+)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-04-30 18:49:44 UTC
Thank you for your contribution.