Bug 257251 (meson-0.59.1)

Summary: [exp-run] Update devel/meson to 0.59.1
Product: Ports & Packages Reporter: Tobias C. Berner <tcberner>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: contact, desktop, jbeich, vishwin
Priority: --- Flags: antoine: exp-run+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1
none
v2
none
v3 (apply via "git am") none

Description Tobias C. Berner freebsd_committer freebsd_triage 2021-07-18 14:09:55 UTC
Created attachment 226532 [details]
v1

Moin moin 

desktop@ would like to ask for an exp-run to update devel/meson to 0.59.0. 

The patch is attached, and can also be found here:
https://people.freebsd.org/~tcberner/patches/0001-devel-meson-update-to-0.59.0.patch

mfg Tobias
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-07-19 04:07:56 UTC
*** Bug 257260 has been marked as a duplicate of this bug. ***
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-07-27 11:05:38 UTC
astro/siril: meson-0.59.0 changed how cmake-subprojects name their libraries.

See [1] and [2] for the details.

[1] https://github.com/mesonbuild/meson/commit/0d0f2cdafd7597ff84baf7a4790f3f016fe2337f
[2] https://github.com/mesonbuild/meson/issues/8955
Comment 4 Simon Ser 2021-08-12 08:25:08 UTC
Hi, any news about this? What are the remaining issues with the upgrade?
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-08-12 09:22:14 UTC
(In reply to Simon Ser from comment #4)
Moin moin 

It has not the highest priority to add manual fixes, as this is an upstream issue (that will either get resolved in meson in the .1 release, or within the usage in gnome*).

Last time I checked there was no fix available yet. If you have fixes avaialable or know where they are, we can add them.


mfg Tobias
Comment 6 Simon Ser 2021-08-12 09:24:29 UTC
Hm, what is the issue exactly? Is upstream aware of it? Can't find anything in the links above.
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2021-08-12 09:32:04 UTC
(In reply to Simon Ser from comment #6)
IIRC: https://github.com/mesonbuild/meson/issues/9009
Comment 8 Simon Ser 2021-08-12 09:33:32 UTC
(In reply to Tobias C. Berner from comment #7)

Thanks! Will wait for 0.59.1 then.
Comment 9 Simon Ser 2021-08-19 18:38:59 UTC
0.59.1 is now released: https://github.com/mesonbuild/meson/releases/tag/0.59.1
Comment 10 Charlie Li freebsd_committer freebsd_triage 2021-08-20 17:42:12 UTC
Created attachment 227347 [details]
v2

0.59.1
Comment 12 Jan Beich freebsd_committer freebsd_triage 2021-09-03 01:00:41 UTC
Created attachment 227631 [details]
v3 (apply via "git am")

Antoine, did you test other release/architecture tuples? Ideally, I'd like to land this before Saturday 01:00 UTC package build starts.

- astro/siril is fixed by v3
- games/taisei was fixed ports 2ed037639e9b
- "make patch" warning "No such line 37 in input file, ignoring" is fixed in v3
- Improved commit message in v3 (should I switch to "Co-authored-by"?)
Comment 13 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-03 01:21:22 UTC
(In reply to Jan Beich from comment #12)
lgtm with desktop@-hat -- feel free to land, once the exp-run is through.
Comment 14 Antoine Brodin freebsd_committer freebsd_triage 2021-09-05 19:27:24 UTC
Exp-run looks fine
Comment 15 commit-hook freebsd_committer freebsd_triage 2021-09-05 20:32:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=751f060df08bb93132b7869a41190da87cecaeb8

commit 751f060df08bb93132b7869a41190da87cecaeb8
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-09-03 01:00:41 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-09-05 20:31:18 +0000

    devel/meson: fix patch warning after afb3593eef00

    ===>  Patching for meson-0.58.1
    ===>  Applying FreeBSD patches for meson-0.58.1 from /a/ports/devel/meson/files
    No such line 37 in input file, ignoring

    PR:             257251
    Approved by:    tcberner

 devel/meson/files/patch-setup.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 16 commit-hook freebsd_committer freebsd_triage 2021-09-05 20:32:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2b36c4b4615929fffaf8269bd3d15e26af757225

commit 2b36c4b4615929fffaf8269bd3d15e26af757225
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-08-18 11:22:15 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-09-05 20:31:23 +0000

    devel/meson: update to 0.59.1

    Changes:        https://mesonbuild.com/Release-notes-for-0-59-0.html
    PR:             257251
    Reported by:    GitHub (watch releases)
    Submitted by:   tcberner, vishwin (based on)
    Exp-run by:     antoine
    Approved by:    tcberner

 astro/siril/Makefile  | 2 +-
 astro/siril/pkg-plist | 2 +-
 devel/meson/Makefile  | 2 +-
 devel/meson/distinfo  | 6 +++---
 4 files changed, 6 insertions(+), 6 deletions(-)
Comment 17 Jan Beich freebsd_committer freebsd_triage 2021-09-05 20:33:06 UTC
(In reply to Jan Beich from comment #12)
> - "make patch" warning "No such line 37 in input file, ignoring" is fixed in v3

Was a bug 255550 regression, so landed in a separate commit.