Bug 25733

Summary:	[intpm] mismatch between error reporting in smbus framework and intpm driver
Product:	Base System	Reporter:	pa <pa>
Component:	kern	Assignee:	Andriy Gapon <avg>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any

Description pa 2001-03-12 11:40:00 UTC

	smbus_quick, smbus_sendb, smbus_recvb, smbus_writeb, smbus_writew, smbus_readb, smbus_readw, smbus_pcall, smbus_bwrite, smbus_bread expects SMB_E????
	but the intpm counterparts return ordinary E????

How-To-Repeat: 	Inspect code

Comment 1 dfilter service freebsd_committer

2012-04-08 21:48:48 UTC

Author: avg
Date: Sun Apr  8 20:48:39 2012
New Revision: 234043
URL: http://svn.freebsd.org/changeset/base/234043

Log:
  intpm: return only SMB bus error codes from SMB methods
  
  PR:		kern/25733
  MFC after:	5 days

Modified:
  head/sys/pci/intpm.c

Modified: head/sys/pci/intpm.c
==============================================================================
--- head/sys/pci/intpm.c	Sun Apr  8 20:44:57 2012	(r234042)
+++ head/sys/pci/intpm.c	Sun Apr  8 20:48:39 2012	(r234043)
@@ -272,7 +272,7 @@ intsmb_callback(device_t dev, int index,
 	case SMB_RELEASE_BUS:
 		break;
 	default:
-		error = EINVAL;
+		error = SMB_EINVAL;
 	}
 
 	return (error);
@@ -519,7 +519,7 @@ intsmb_quick(device_t dev, u_char slave,
 		data |= LSB;
 		break;
 	default:
-		return (EINVAL);
+		return (SMB_EINVAL);
 	}
 
 	INTSMB_LOCK(sc);
@@ -774,7 +774,7 @@ intsmb_bread(device_t dev, u_char slave,
 			}
 			*count = nread;
 		} else
-			error = EIO;
+			error = SMB_EBUSERR;
 	}
 	INTSMB_UNLOCK(sc);
 	return (error);
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 2 Andriy Gapon freebsd_committer

2012-04-08 21:54:36 UTC

Responsible Changed
From-To: freebsd-bugs->avg

Take.

Comment 3 Andriy Gapon freebsd_committer

2012-04-16 13:08:58 UTC

State Changed
From-To: open->patched

A patch is committed to head.

Comment 4 Andriy Gapon freebsd_committer

2012-04-25 08:32:32 UTC

State Changed
From-To: patched->closed

The fix is merged to all supported branches.