Summary: | [NEW PORT] multimedia/py-mat2: Handy tool to trash your metadata | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Robert Clausecker <fuz> | ||||||
Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | fuz, grahamperrin, lwhsu, python | ||||||
Priority: | --- | Keywords: | feature | ||||||
Version: | Latest | Flags: | fuz:
maintainer-feedback+
|
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://0xacab.org/jvoisin/mat2 | ||||||||
Attachments: |
|
Description
Robert Clausecker
2021-07-22 14:12:43 UTC
Thanks for submittinng a new port Robert! Initial review items: - COMMENT: Match upstream metadata as completely and closely as possible. [1] - CATEGORIES: Always include python category unless use of Python is entirely irrelevant. [2] I'd trim the list too. Pick 3 with one obvious primary. Id suggest: sysutils security python - Use MASTER_SITES=CHEESESHOP (PyPI) unless tests or other important files are missing. Use standard Python ecosystem infrastructure whenever possible. [3] - RUN_DEPENDS: Upstream declares pycairo in install_requires, but is missing here? - RUN_DEPENDS: Make optional dependencies OPTIONS whenever possible. - This package installs files into non version specific places (setup.py:console_scripts/scripts installs into LOCALBASE/bin/*), so needs to be made concurrent (installation) safe. USE_PYTHON=concurrent [4] [1] https://wiki.freebsd.org/Python/PortsPolicy#COMMENT [2] https://wiki.freebsd.org/Python/PortsPolicy#CATEGORIES [3] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES [4] https://wiki.freebsd.org/Python/PortsPolicy#concurrent (In reply to Kubilay Kocak from comment #1) Hi, Thanks for raising these issues. This is my first Python port and I will go ahead and address them in a revised patch. > RUN_DEPENDS: Upstream declares pycairo in install_requires, but is missing here? This is pulled in as a transitive dependency through py38-gobject3. If desired, I can go ahead and make it an explicit dependency. > - CATEGORIES: Always include python category unless use of Python is entirely irrelevant. [2] I'd trim the list too. Pick 3 with one obvious primary. Id suggest: sysutils security python Thanks, I had perhaps misunderstood the policy here and assumed the python group was for ports from the Python project only. Sysutils is not a good choice since the purpose of this document is to modify media files and documents (hence multimedia, audio, textproc). Created attachment 226629 [details]
multimedia/py-mat2: Handy tool to trash your metadata
Fixed patch applying QA feedback.
It might be a good idea to link this Python policy page in the Porter's handbook. I was not aware there was more policy than what the handbook said.
Forgot to mention, of course I also tested the updated the patch with Poudriere on amd64 i386 arm64 armv7 FreeBSD 13.0. So QA has been performed. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bfd59f03a3608727ef8a26298d3ac7ea8d003a37 commit bfd59f03a3608727ef8a26298d3ac7ea8d003a37 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2021-07-22 12:53:48 +0000 Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> CommitDate: 2021-08-03 19:30:44 +0000 multimedia/py-mat2: (New) Handy tool to trash your metadata PR: 257336 multimedia/Makefile | 1 + multimedia/py-mat2/Makefile (new) | 30 ++++++++++++++++++++++++++++++ multimedia/py-mat2/distinfo (new) | 3 +++ multimedia/py-mat2/pkg-descr (new) | 24 ++++++++++++++++++++++++ 4 files changed, 58 insertions(+) |