Bug 257358
| Summary: | [NEW PORT] www/writefreely: Clean, Markdown-based publishing platform made for writers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Robert Clausecker <fuz> | ||||||
| Component: | Individual Port(s) | Assignee: | Joseph Mingrone <jrm> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | FreeBSD, diizzy, jrm, lwhsu | ||||||
| Priority: | --- | Keywords: | feature | ||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://writefreely.org | ||||||||
| Attachments: |
|
||||||||
|
Description
Robert Clausecker
2021-07-23 15:30:51 UTC
Have you looked at www/rubygem-less ? (In reply to Shane from comment #1) There seem to be syntax errors when using this one as well. Created attachment 226780 [details]
226635: www/writefreely: Clean, Markdown-based publishing platform made for writers
Update patch with different UID/GID values as the old UID/GID pair had been taken in the meanwhile.
files/pkg-message.in seems not in the latest format (UCL), can you check this? Thanks! (In reply to Li-Wen Hsu from comment #4) Yes, this is intentional. The message only needs to be shown on installation, so an old-style message suffices. https://www.freshports.org/www/py-lesscpy/ --> https://github.com/lesscpy/lesscpy (upstream released new version about a month ago) ? In general I think we should avoid relying on the maintainer to be a part of upstream as that usually causes issue futher down the road pretty much the same as for ports with non upstreamed patches. Why is DIST_SUBDIR defined? (In reply to Daniel Engberg from comment #6) DIST_SUBDIR is defined because this port has a lot of distfiles, many of which are shared with www/writeas-cli. The Porter's Handbook recommends defining DIST_SUBDIR in such cases. The Makefile actually comes with a target to generate the hand-rolled distfile, so in case the maintainer changes, the new maintainer has a way to generate it. But indeed, I would prefer to avoid doing it this way. I can try using py-lesscpy in the new version (the old version didn't work as indicated in the PR description). (In reply to Daniel Engberg from comment #6) lesscpy 0.15.0 doesn't like the files either: lesscpy app.less < E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/core.less line: 1154, Syntax Error, token: `t_comma`, `,`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/core.less line: 1186, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/core.less line: 1546, Syntax Error, token: `css_ident`, `pointer`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/core.less line: 1557, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/core.less line: 1583, Syntax Error, token: `t_bclose`, `}`E: line: 0: Unknown variable @sansFont E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad.less line: 517, Syntax Error, token: `css_ident`, `pointer`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad-theme.less line: 40, Syntax Error, token: `t_comma`, `,`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad-theme.less line: 49, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad-theme.less line: 84, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad-theme.less line: 186, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/pad-theme.less line: 207, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 34, Syntax Error, token: `css_ident`, `fadeIn`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 34, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 36, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 37, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 38, Syntax Error, token: `t_bclose`, `}`E: /usr/home/fuz.ports/www/writefreely/work/writefreely-0.13.1/less/effects.less line: 39, Syntax Error, token: `t_bclose`, `}`E: line: 0: Unknown variable @sansFont E: line: 0: Unknown variable @sansFont E: line: 0: Unknown variable @sansFont (In reply to Li-Wen Hsu from comment #4) Hi Li-Wen, Is there anything left that prevents the port from being committed? (In reply to Robert Clausecker from comment #5) I suggest let's follow the latest convention for consistency across the ports tree, which is easier for others to reference. I can do the modification, but if you don't mind to update the patch, it would be great. (In reply to Li-Wen Hsu from comment #10) Yes, please perform the modification when you make the commit. My ports building machines are currently busy with other things, so it would take quite a while for me to get an updated patch ready. Next time, please tell me directly that you expect me to change something instead of making vague remarks and then just waiting and doing nothing. This saves all of us a lot of time. And I really want to move on to other work. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6da4b7abdb3d56fa4c810acfbd09c683026edac3 commit 6da4b7abdb3d56fa4c810acfbd09c683026edac3 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2021-08-22 03:08:31 +0000 Commit: Joseph Mingrone <jrm@FreeBSD.org> CommitDate: 2021-08-22 15:09:59 +0000 www/writefreely: Clean, markdown-based publishing for writers https://writefreely.org PR: 257358 Reviewed by: lwhsu GIDs | 2 +- UIDs | 2 +- www/Makefile | 1 + www/writefreely/Makefile (new) | 156 ++++++++++++ www/writefreely/distinfo (new) | 149 +++++++++++ www/writefreely/files/patch-go.mod (new) | 27 ++ www/writefreely/files/patch-go.sum (new) | 61 +++++ www/writefreely/files/patch-gopher.go (new) | 11 + www/writefreely/files/patch-handle.go (new) | 11 + www/writefreely/files/pkg-message.in (new) | 15 ++ www/writefreely/files/writefreely.in (new) | 65 +++++ www/writefreely/pkg-descr (new) | 5 + www/writefreely/pkg-plist (new) | 374 ++++++++++++++++++++++++++++ 13 files changed, 877 insertions(+), 2 deletions(-) (In reply to Robert Clausecker from comment #11) I was not just waiting and doing nothing. As you said this port is huge and needs review. It takes time and I was trying my best to make little progress step by step when I am available. For the record, I didn't expect you to change something or making vague remarks in comment #4, it was a question during the review for the original intention. I didn't test it fully on my side so didn't have put comment. When you asked again, I can only put the current feedback. I was still working on editing and testing, they also take time as you working on it or others. I am very sorry for delaying your progress. I just wanted to help your as much as I can since you ask for help for this port for a long time. I'll be more careful and estimate my ability next time when taking your tickets. Sorry again for failing your expectation. |