Bug 257363
| Summary: | net/gitup not cleaning stale patches in ports tree | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Marek Zarychta <zarychtam> |
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> |
| Status: | Closed Overcome By Events | ||
| Severity: | Affects Only Me | CC: | dougs, grahamperrin, zarychtam |
| Priority: | --- | Keywords: | dogfood, needs-patch, needs-qa |
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(eduardo) |
| Hardware: | Any | ||
| OS: | Any | ||
I see people subscribing to this bug. Are you affected too? (In reply to Marek Zarychta from comment #1) > … Are you affected too? I don't know, I rarely use gitup, I did find myself bugged by <https://github.com/johnmehr/gitup/issues/69> on a test machine. (In reply to Marek Zarychta from comment #1) Yes. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=89e756a683a7d889937202036bfb9f13eab220f1 commit 89e756a683a7d889937202036bfb9f13eab220f1 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2021-07-25 13:23:35 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-07-25 13:23:35 +0000 net/gitup: Update to 0.95 ChangeLog: https://github.com/johnmehr/gitup/releases/tag/0.95 PR: 257363 net/gitup/Makefile | 2 +- net/gitup/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Hello, I've updated port to latest version and I'm starting doing tests to see if I get same errors as listed. Please let me know if problem continues so we could open an issue at upsream based on this PR. Cheers (In reply to Nuno Teixeira from comment #5) And my gitup.conf is a fresh one: "ports" : { "repository_path" : "/ports.git", "branch" : "main", "target_directory" : "/usr/ports", "ignores" : [ "distfiles", "packages", "INDEX-11", "INDEX-12", "INDEX-13", "INDEX-14", ], }, Thank you for taking care of this. I will test and let you know if it helped. I will close this PR since there is no issues at gitup site. |
net/gitup with this config: "ports" : { "repository" : "/ports.git", "branch" : "main", "target" : "/usr/ports", "ignores" : [ "distfiles", "packages", ], }, is leaving stale patches, for example after recent texinfo update after running "gitup ports" it has left /usr/ports/texinfo/files/patch-tp-Texinfo-XS-parsetexi-Parser-5556.pm and patch-tp-Texinfo-XS-parsetexi-errors.c which both should have been deleted. Such a mess leads usually only to breakage at the patching stage (see below), but could probably lead to more pessimistic endings. ===> Patching for texinfo-6.8,1 ===> Applying FreeBSD patches for texinfo-6.8,1 from /usr/ports/print/texinfo/files File to patch: ^C===> FAILED Applying FreeBSD patch-tp-Texinfo-XS-parsetexi-Parser-5556.pm ===> FAILED to apply cleanly FreeBSD patch(es) patch-tp-Texinfo-XS-parsetexi-Parser-5556.pm *** Error code 1 *** Signal 2 It's only an example, I have fallen into this many times, especially while updating python modules.