Bug 257442
| Summary: | devel/tevent: Update to 0.12.1 and tweak Makefile | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||
| Component: | Individual Port(s) | Assignee: | Timur I. Bakeyev <timur> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | diizzy | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(timur) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | 257432 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
Tests also fail without Python support enabled (hard depend on Python bindings) Created attachment 226836 [details]
Patch for tevent v2
Add missing dependency for Python variant
Strip all libraries
Only include bsd.port.mk
Friendly ping Created attachment 234594 [details] Patch for tevent v3 Update to 0.12.1 make test passes on FreeBSD 13.1 (amd64) Unfortunately upstream doesn't seem to provide release/change notes https://github.com/samba-team/samba/commits/master/lib/tevent A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ef9a3b42d9a41e6d4ddcfef8abb9e560a1534044 commit ef9a3b42d9a41e6d4ddcfef8abb9e560a1534044 Author: Timur I. Bakeyev <timur@FreeBSD.org> AuthorDate: 2022-07-29 12:16:02 +0000 Commit: Timur I. Bakeyev <timur@FreeBSD.org> CommitDate: 2022-07-30 00:07:50 +0000 devel/tevent: Update 0.10.2 to 0.13.0 PR: 257442 devel/tevent/Makefile | 159 ++++++++++++++++++------------------------- devel/tevent/distinfo | 6 +- devel/tevent/pkg-plist (new) | 7 ++ 3 files changed, 75 insertions(+), 97 deletions(-) Hi, Daniel! Same changes to your patch here. Committed, thank you! Timur No worries, I have a few questions about the final version though. Why is talloc defined as BUILD and RUN depdency when it's linked? Any reason why you don't use cmocka in tree? Why is += used when its the first time the variable is defined? This is incorrect if you look at Porters Handbook in most cases Best regards, Daniel |
Created attachment 226725 [details] Patch for tevent Update (lib)tevent to 0.11.0 PORTVERSION --> DISTVERSION Use LIB_DEPENDS instead of BUILD_ and RUN_DEPENDS Remove tests for multiprocessing python pacakge/module, all versions in tree ships it Remove very old CONFLITCS entry Utilize ports framework to remove several if statements Drop color output settings Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 11.4-RELEASE (amd64)