Bug 257494

Summary: sysutils/lsblk: update to 3.6
Product: Ports & Packages Reporter: Slawomir Wojciech Wojtczak <vermaden>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Many People CC: grahamperrin, lwhsu
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 257409    
Attachments:
Description Flags
lsblk.diff none

Description Slawomir Wojciech Wojtczak 2021-07-29 21:59:16 UTC
Created attachment 226788 [details]
lsblk.diff

Hi,

I have fixed several lsblk(8) bugs.

Please update the port if you have the time.

Here is the changelog if needed:

- Fix label display.
- Improve FUSE filesystems display.
- Fix whole disks display.
- Make more space for labels display in output.

I attached the diff(1) output according to this documentation:
https://docs.freebsd.org/en/books/porters-handbook/upgrading/

Hope that helps.

Regards.
Comment 1 Li-Wen Hsu freebsd_committer 2021-07-30 05:48:40 UTC
(In reply to vermaden from comment #0)
Thanks for the patch. If possible, please set your name in https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so we can use it in `git commit --author` .
Comment 2 Slawomir Wojciech Wojtczak 2021-07-30 10:32:20 UTC
(In reply to Li-Wen Hsu from comment #1)

Added ... but its more chance that you will find me by the name 'vermaden' then by my 'real' name :)
Comment 3 commit-hook freebsd_committer 2021-07-30 19:15:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7807810e92f3dabe51e1bd2c0c6dd07ff6fc84cb

commit 7807810e92f3dabe51e1bd2c0c6dd07ff6fc84cb
Author:     Slawomir Wojciech Wojtczak <vermaden@interia.pl>
AuthorDate: 2021-07-30 19:13:27 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-30 19:14:24 +0000

    sysutils/lsblk: Update to 3.6

    Changelog:

    - Fix label display.
    - Improve FUSE filesystems display.
    - Fix whole disks display.
    - Make more space for labels display in output.

    PR:             257494

 sysutils/lsblk/Makefile | 2 +-
 sysutils/lsblk/distinfo | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 4 Li-Wen Hsu freebsd_committer 2021-07-30 19:19:44 UTC
(In reply to Slawomir Wojciech Wojtczak from comment #2)
Thanks, you can also have (vermaden) in the name if you want. :-)

Is this version safe for MFH?  I know it fixes some bugs but it looks not a security issue so we want to ensure compatibility before merging.
Comment 5 Slawomir Wojciech Wojtczak 2021-07-30 19:22:20 UTC
(In reply to Li-Wen Hsu from comment #4)

It contains only fixes and no new features - I would say that 3.6 is safer then 3.5 because it works better.
Comment 6 commit-hook freebsd_committer 2021-07-30 19:24:15 UTC
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4735ff018624c1215c42232c0fae2a6382f843d5

commit 4735ff018624c1215c42232c0fae2a6382f843d5
Author:     Slawomir Wojciech Wojtczak <vermaden@interia.pl>
AuthorDate: 2021-07-30 19:13:27 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-30 19:23:41 +0000

    sysutils/lsblk: Update to 3.6

    Changelog:

    - Fix label display.
    - Improve FUSE filesystems display.
    - Fix whole disks display.
    - Make more space for labels display in output.

    PR:             257494
    (cherry picked from commit 7807810e92f3dabe51e1bd2c0c6dd07ff6fc84cb)

 sysutils/lsblk/Makefile | 2 +-
 sysutils/lsblk/distinfo | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)