Bug 257527

Summary: lang/ruby27: add DTRACE option
Product: Ports & Packages Reporter: Evgeniy Khramtsov <evgeniy>
Component: Individual Port(s)Assignee: freebsd-ruby (Nobody) <ruby>
Status: New ---    
Severity: Affects Only Me CC: evgeniy, swills
Priority: --- Keywords: patch
Version: LatestFlags: evgeniy: maintainer-feedback-
evgeniy: maintainer-feedback?
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257525
Attachments:
Description Flags
v1 (use "git am")
evgeniy: maintainer-approval?
patch to ruby port none

Description Evgeniy Khramtsov 2021-08-01 09:47:18 UTC
Created attachment 226828 [details]
v1 (use "git am")

- add DTRACE option for user to decide

lang/ruby26 assumes that DTrace support is guarded by exists() check,
failing when base toolchain is removed, and instead external toolchain
is provided by ports via /usr/local/share/toolchains/*.mk inclusion.

- remove ${OPSYS} == "FreeBSD" check

DTrace does not exist on DragonFly BSD, the only known consumer of FreeBSD ports.

- Bump PORTREVISION per [1]

poudriere testport (post-patch) Tier 1 arch logs:
https://codeberg.org/ei/misc/commit/22ec334270277410067b24f9120022837cc1216d

poudriere bulk diff (post-patch) Tier 1 arch logs:
https://codeberg.org/ei/misc/commit/40a03285b80d6b49a49f8755ac97aefb493689b4

poudriere package diff (post-patch) Tier 1 arch logs [1]:
https://codeberg.org/ei/misc/commit/8f6a59914e4acd5f57633935d07ae73985c0af08

Note, 11.4 has modified usr/local/lib/libruby* entries. This is not caused
by this change, instead caused by any rebuild instead. Apparently, timestamp
or something else gets baked in on 11.4, so 11.4 Ruby is not reproducible. I
don't know any tool to diff binaries to tell what exactly is not reproducible.

RUBY_PORTREVISION bump is not included in this patch, git commit --amend
if committing.

UPDATING entry is not needed, the default behaviour of port did not change,
users who disable DTRACE globally will get notified via "options changed"
of poudriere.

lang/ruby30 change is omitted due to:
https://cgit.freebsd.org/ports/commit/?id=95fa9913f79cd0c31f0cc4df2294d934f5368bc5

Note the commented out DTrace section. I don't yet use lang/ruby30,
I don't know the reason behind this commented out section, I can't
reasonably QA lang/ruby30. Changing lang/ruby30 is up to maintainer.
Comment 2 Evgeniy Khramtsov 2021-09-05 22:59:02 UTC
Maintainer timeout (1 month).

Maybe add this option for ports tree consistency,
e.g. do the same as databases/memcached, databases/postgresql14-server,
lang/perl5.34, lang/erlang-runtime24, lang/ponyc, www/node,
and many other ports that have optional DTRACE?
Comment 3 Steve Wills freebsd_committer 2021-09-06 19:04:41 UTC
Created attachment 227716 [details]
patch to ruby port

This might help instead.