Summary: | net/openldap24-server: Fix breakage after SASL changes | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Rainer Hurling <rhurlin> | ||||
Component: | Individual Port(s) | Assignee: | Xin LI <delphij> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | rhurlin | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(delphij) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Thanks for pointing this out. I've committed a different patch (to move the option earlier). A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=80df02c5cbfa308542602c54645bbc574031316f commit 80df02c5cbfa308542602c54645bbc574031316f Author: Xin LI <delphij@FreeBSD.org> AuthorDate: 2021-08-01 19:08:52 +0000 Commit: Xin LI <delphij@FreeBSD.org> CommitDate: 2021-08-01 19:10:11 +0000 net/openldap24-server: Fix GSSAPI dependency <OPTION>_RUN_DEPENDS has to appear before bsd.options.mk. PR: 257529 net/openldap24-server/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |
Created attachment 226834 [details] patch to fix RUN_DEPENDS after using bsd.port.options.mk Hi Xin LI, Thanks for the SASL changes in net/openldap24-server. Unfortunetaly there seem to be a breakage with this new code: #cd net/openldap24-client #make /!\ openldap-client-2.4.59_1: Makefile errors /!\ The following options helpers are incorrectly set after bsd.port.options.mk and are ineffective: GSSAPI_RUN_DEPENDS *** Error code 1 Stop. This happens, because GSSAPI_RUN_DEPENDS (in the servers Makefile) is used after '.include <bsd.port.options.mk>'. The attached patch changes this to old style RUN_DEPENDS in an .if/.endif. This should work as expected, I hope. Regards, Rainer