Summary: | ld: error: undefined symbol: xen_clock_init | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | andy | ||||
Component: | kern | Assignee: | Roger Pau Monné <royger> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | dim, lwhsu, royger, toolchain | ||||
Priority: | --- | ||||||
Version: | CURRENT | ||||||
Hardware: | amd64 | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
andy
2021-08-02 02:24:48 UTC
This starts happening in LINT kernel build after a series of xen related commits: https://ci.freebsd.org/job/FreeBSD-main-amd64-LINT/20137/ Created attachment 226870 [details]
Fix
The attached patch should fix the issue, will commit very soon unless someone objects.
Looks fine to me :) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=82bf6a2566ba51f2516c16aa7cca6398972c3123 commit 82bf6a2566ba51f2516c16aa7cca6398972c3123 Author: Roger Pau Monné <royger@FreeBSD.org> AuthorDate: 2021-08-02 08:22:22 +0000 Commit: Roger Pau Monné <royger@FreeBSD.org> CommitDate: 2021-08-02 08:33:35 +0000 xen/timer: fix amd64 LINT kernel build On amd64 XENHVM depends on the xentimer device for PVH early startup, so both should be added or removed together (like the current dependency with xenpci). Fix this by adding xentimer to NOTES and updating the comments on the config files. Note that on i386 there's no such dependency between xentimer and XENHVM, since there's no PVH support. While there also fix the MINIMAL i386 build to include the xentimer, so it keeps the same functionality as before xentimer was split from XENHVM. Reported by: lwhsu PR: 257549 Fixes: ae5981274815 ('xen/timer: make xen timer optional') sys/amd64/conf/GENERIC | 4 ++-- sys/amd64/conf/MINIMAL | 4 +++- sys/amd64/conf/NOTES | 1 + sys/i386/conf/MINIMAL | 1 + 4 files changed, 7 insertions(+), 3 deletions(-) |