Bug 257604

Summary:

graphics/libnsgif: respect CC

Product:

Ports & Packages

Reporter:

Ghost <2khramtsov>

Component:

Individual Port(s)

Assignee:

Neel Chauhan <nc>

Status:

Closed FIXED

Severity:

Affects Only Me

Keywords:

patch

Priority:

---

Flags:

nc: maintainer-feedback+
2khramtsov: maintainer-feedback?

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
v1 (use "git am")	none

Description Ghost 2021-08-04 05:56:36 UTC

Created attachment 226929 [details]
v1 (use "git am")

Add BUILD_CC to unbreak the build when the base toolchain (/usr/bin/cc)
does not exist, and CC is provided via inclusion of /usr/share/toolchains.

11.4/amd64: OK
bulk diff https://codeberg.org/ei/misc/commit/83cb8cf
pkg diff https://codeberg.org/ei/misc/commit/bb14270
testport https://codeberg.org/ei/misc/commit/05e1f19

11.4/i386 OK:
bulk diff https://codeberg.org/ei/misc/commit/de3e3f6
pkg diff https://codeberg.org/ei/misc/commit/35de6dd
testport https://codeberg.org/ei/misc/commit/f334170

12.2/amd64: OK
bulk diff https://codeberg.org/ei/misc/commit/0cc1ff4
pkg diff https://codeberg.org/ei/misc/commit/7ad7932
testport https://codeberg.org/ei/misc/commit/08480f7

12.2/i386: OK
bulk diff https://codeberg.org/ei/misc/commit/e4f9bc5
pkg diff https://codeberg.org/ei/misc/commit/09f0e03
testport https://codeberg.org/ei/misc/commit/bbb184a

13.0/amd64: OK
bulk diff https://codeberg.org/ei/misc/commit/08480f7
pkg diff https://codeberg.org/ei/misc/commit/d9ac2b8
testport https://codeberg.org/ei/misc/commit/8f4d107

13.0/aarch64 (via qemu-user-static): OK
bulk diff https://codeberg.org/ei/misc/commit/df8ba05
pkg diff https://codeberg.org/ei/misc/commit/16562cb
testport https://codeberg.org/ei/misc/commit/1de0495

Comment 1 Ghost 2021-08-08 11:58:56 UTC

Steps to reproduce: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257622#c5

devel/netsurf-buildsystem has "BUILD_CC?=" in its files, and the ports using it are affected. See my PRs.

Also https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-cc

Comment 2 Neel Chauhan freebsd_committer

2021-08-08 12:00:12 UTC

LGTM. Sorry for the delay.

Comment 3 Neel Chauhan freebsd_committer

2021-08-08 12:02:05 UTC

Committed!

Comment 4 commit-hook freebsd_committer

2021-08-08 12:04:02 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1da0a1c27a986fa004f6f945a4bf1d4d2a1d783

commit a1da0a1c27a986fa004f6f945a4bf1d4d2a1d783
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-08-08 12:01:30 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-08-08 12:01:30 +0000

    graphics/libnsgif: respect CC in MAKE_ENV

    PR:     257604

 graphics/libnsgif/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)