Summary: | security/gvm-libs: 21.4.1 build fails (incomplete type 'crypt_data', etc.) | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||
Component: | Individual Port(s) | Assignee: | Jose Alonso Cardenas Marquez <acm> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | acm | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(acm) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
John Hein
2021-08-06 10:37:46 UTC
Created attachment 226993 [details]
[patch] don't build code that requires crypt_r on 11.x
This patch fixes the problem on 11.x (which does not have crypt_r). No change for 12.x+
The patch skips compiling pba_hash() and pba_verify_hash() on FreeBSD 11.x which (currently) does not have crypt_r(3).
This can be removed when support for 11.x is no longer needed in the ports tree.
A better upstream patch might be to detect the missing crypt_r(3) via cmake. But this patch seemed easier - and it addresses a short-lived problem during the remaining time until 11.x is EOL.
But if someone else wants to touch cmake for this, feel free. I might be more inclined to do that myself were it not cmake.
There is no need to bump PORTREVISION for this as it fixes a build bug which prevents any packages to be generated for 11.x anyway.
openvas builds fine with this change.
QA:
poudriere - ok (stable-11/amd64)
portlint - ok (no new warnings or errors, but there are lots of pre-existing ones that could be addressed - these are not in the scope of this bug)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a65d2f7cdef55aee89e8fc9984df706eff65538a commit a65d2f7cdef55aee89e8fc9984df706eff65538a Author: Jose Alonso Cardenas Marquez <acm@FreeBSD.org> AuthorDate: 2021-09-05 02:06:04 +0000 Commit: Jose Alonso Cardenas Marquez <acm@FreeBSD.org> CommitDate: 2021-09-05 02:11:19 +0000 security/gvm: update to 21.4.2 The following ports part of security gvm were updated security/gvmd: Update to 21.4.3 security/gvm-libs: Update to 21.4.2 security/openvas: Update to 21.4.2 security/py-ospd-openvas: Update to 21.4.2 security/py-ospd: Update to 21.4.3 security/greenbone-security-assistant: Update to 21.4.2 - Fix build on FreeBSD 11 [1] PR: 257653 Reported by: John Hein <jcfyecrayz _ at _ liamekaens.com> [1] security/greenbone-security-assistant/Makefile | 2 +- security/greenbone-security-assistant/distinfo | 6 +++--- .../files/patch-gsad_CMakeLists.txt | 23 +++++++++++----------- security/gvm-libs/Makefile | 2 +- security/gvm-libs/distinfo | 6 +++--- .../files/patch-util_passwordbasedauthentication.c | 21 +++++++++++++++++--- .../patch-util_passwordbasedauthentication.h (new) | 15 ++++++++++++++ security/gvm-libs/pkg-plist | 10 +++++----- security/gvm/Makefile | 2 +- security/gvmd/Makefile | 2 +- security/gvmd/distinfo | 6 +++--- security/gvmd/pkg-plist | 2 +- security/openvas/Makefile | 2 +- security/openvas/distinfo | 6 +++--- security/openvas/pkg-plist | 4 ++-- security/py-ospd-openvas/Makefile | 2 +- security/py-ospd-openvas/distinfo | 6 +++--- security/py-ospd/Makefile | 2 +- security/py-ospd/distinfo | 6 +++--- security/py-ospd/files/patch-setup.py (new) | 11 +++++++++++ 20 files changed, 89 insertions(+), 47 deletions(-) - Committed thanks! |