Bug 25779

Summary: (patch) make fetch-list should list all master sites
Product: Ports & Packages Reporter: Trevor Johnson <trevor>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Trevor Johnson 2001-03-13 18:50:01 UTC 
The fetch-list target is intended "to do a batch fetch" but its output
only names one master site for each distfile, even when multiple sites are
available.  If that site fails, the distfile will not be fetched at all.

Fix: 

http://people.freebsd.org/~trevor/ports/fetch-list.diff
How-To-Repeat: 
"make fetch-list" for any port with multiple master sites
Comment 1 Trevor Johnson freebsd_committer freebsd_triage 2001-03-15 12:00:20 UTC 
Responsible Changed
From-To: freebsd-ports->asami

bsd.port.mk
Comment 2 Will Andrews freebsd_committer freebsd_triage 2001-04-04 09:21:08 UTC 
Responsible Changed
From-To: asami->portmgr

Over to new maintainer.
Comment 3 Kris Kennaway 2003-02-01 23:05:56 UTC 
I'm not sure this patch will DTRT.  I'm assuming a common use of the
'fetch-list' target is to pass to an external download program to
download distfiles at once, but if the same file is listed e.g. 20
times then it will be downloaded 20 times.

Kris
Comment 4 Kris Kennaway freebsd_committer freebsd_triage 2003-02-01 23:06:06 UTC 
State Changed
From-To: open->analyzed

Not sure this will DTRT.
Comment 5 Trevor Johnson 2003-02-01 23:22:43 UTC 
> I'm not sure this patch will DTRT.  I'm assuming a common use of the
> 'fetch-list' target is to pass to an external download program to
> download distfiles at once, but if the same file is listed e.g. 20
> times then it will be downloaded 20 times.

That depends on the downloading program.  Both the "fetch" utility which
is part of FreeBSD, and the GNU "wget" utility have options which suppress
such behaviour.

Alternatively, duplicate lines can trivially be removed by filtering
through "sort -u".

Did you try the patch and see duplicate lines in the output?
-- 
Trevor Johnson
Comment 6 Trevor Johnson 2003-02-01 23:30:58 UTC 
I wrote:

> Did you try the patch and see duplicate lines in the output?

	freefall ~/public_html/ports$ ls -lTu fetch-list.diff
	-rw-r--r--  1 trevor  trevor  707 Mar  2 06:09:02 2002 fetch-list.diff

IMO this PR should not be in the "analyzed" state until someone has at
least looked at the patch.
-- 
Trevor Johnson
Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-08-10 23:55:37 UTC 
State Changed
From-To: analyzed->closed

make fetch-list now outputs all the master sites for a given distfile.  In  
fact, it outputs a single command line that can be used to attempt to fetch  
a given distfile from each available master site until the file is  
properly downloaded.