Bug 257946

Summary: multimedia/makemkv: update to 1.16.4
Product: Ports & Packages Reporter: Felix Palmen <zirias>
Component: Individual Port(s)Assignee: Matthias Andree <mandree>
Status: Closed FIXED    
Severity: Affects Only Me CC: eduardo, mandree, trueos
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.makemkv.com/download/history.html
Attachments:
Description Flags
update to 1.16.4 zirias: maintainer-approval+

Description Felix Palmen freebsd_committer freebsd_triage 2021-08-19 16:41:03 UTC
Created attachment 227327 [details]
update to 1.16.4

New upstream version, patch should apply with 'git am'.

Commit message:

multimedia/makemkv: update to 1.16.4

Release notes:
* Much better support for discs with Java playlist obfuscation
* Any Java runtime version is now supported, including Java 16
* Mac OS: Support for Mac OS 12.0 Monterey
* Some small improvements
* Bug fixes:
  - Program failed to recognize some AAC streams with exotic channel
    encoding
  - Picture dimensions were displayed incorrectly for some exotic HEVC
    streams
  - Conversion of some DVDs could fail at the very end of title

Updated statically linked libraries:
  - fdk-aac 2.0.2
  - ffmpeg 4.4

Added convenience script to update the free beta key as an example.

On i386, the compiler from linux devtools now randomly segfaults, which
is worked around by setting MAKE_JOBS_UNSAFE=yes for i386.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2021-08-30 15:32:22 UTC
Interim finding, something's hosed on FreeBSD-13 amd64 when building in a running system (make), not using poudriere:

cc1: warning: command line option '-std=c++11' is valid for C++/ObjC++ but not for C [enabled by default]
In file included from /usr/local/include/linux/videodev2.h:65:0,
                 from libavdevice/v4l2-common.h:36,
                 from libavdevice/v4l2.c:35:
/usr/local/include/linux/types.h:9:18: error: conflicting types for '__u64'
 typedef uint64_t __u64;
                  ^
In file included from /usr/include/asm-generic/types.h:7:0,
                 from /usr/include/asm/types.h:4,
                 from libavdevice/v4l2-common.h:34,
                 from libavdevice/v4l2.c:35:
/usr/include/asm-generic/int-ll64.h:30:42: note: previous declaration of '__u64' was here
 __extension__ typedef unsigned long long __u64;
                                          ^
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2021-08-30 16:46:39 UTC
deinstalling v4l_compat fixes the failure I've reported in comment #1.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-08-30 16:49:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e9152521990928a497c4c619c08f01c8a760813

commit 5e9152521990928a497c4c619c08f01c8a760813
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-08-30 16:45:44 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-08-30 16:48:59 +0000

    multimedia/makemkv: Add CONFLICTS_BUILD=v4l_compat

    Approved by:    Felix Palmen (maintainer, via IRC)
    Related to...
    PR:             257946

 multimedia/makemkv/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-08-30 16:49:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a77e668d4d95640a0b1d81dc197bf3fbc1c85e23

commit a77e668d4d95640a0b1d81dc197bf3fbc1c85e23
Author:     Felix Palmen <felix@palmen-it.de>
AuthorDate: 2021-08-19 16:30:43 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-08-30 16:48:58 +0000

    multimedia/makemkv: maintainer update to 1.16.4

    Release notes:
    * Much better support for discs with Java playlist obfuscation
    * Any Java runtime version is now supported, including Java 16
    * Some small improvements
    * Bug fixes:
      - Program failed to recognize some AAC streams with exotic channel
        encoding
      - Picture dimensions were displayed incorrectly for some exotic HEVC
        streams
      - Conversion of some DVDs could fail at the very end of title

    Updated statically linked libraries:
      - fdk-aac 2.0.2
      - ffmpeg 4.4

    Added convenience script to update the free beta key as an example.

    On i386, the compiler from linux devtools now randomly segfaults, which
    is worked around by setting MAKE_JOBS_UNSAFE=yes for i386.

    PR:             257946

 multimedia/makemkv/Makefile                        | 21 +++++++++++++----
 multimedia/makemkv/distinfo                        | 18 +++++++--------
 .../makemkv/files/update-makemkv-key.sh (new +x)   | 27 ++++++++++++++++++++++
 multimedia/makemkv/pkg-plist                       |  1 +
 4 files changed, 54 insertions(+), 13 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-08-30 16:55:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=421d8a31223d363e0b5890184d1a8c3ba1891371

commit 421d8a31223d363e0b5890184d1a8c3ba1891371
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-08-30 16:53:52 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-08-30 16:54:33 +0000

    multimedia/makemkv: fix up CONFLICTS_BUILD

    Pointy hat to:  mandree@
    PR:             257946

 multimedia/makemkv/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)