Bug 257986

Summary: x11-toolkits/gtk40: fix pkg & configure error
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: freebsd-desktop (Team) <desktop>
Status: Closed FIXED    
Severity: Affects Some People CC: desktop, fluffy, jcfyecrayz, nc
Priority: --- Keywords: patch
Version: LatestFlags: fluffy: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[patch] remove CLOUDPRINT option; fix cups configure jcfyecrayz: maintainer-approval? (desktop)

Description John Hein 2021-08-21 16:10:23 UTC
Created attachment 227354 [details]
[patch] remove CLOUDPRINT option; fix cups configure

See also bug 257760 comment 4.

Cloudprint support was removed for gtk40 4.3.2.  From NEWS:

* Printing:
 - Remove the Google Cloud Print backend

For the current revistion of the x11-toolkits/gtk40 port (4.3.2), if the CLOUDPRINT option is on, 'make package', 'make install', and 'make check-plist' all fail due to a non-existent file.

For example, 'make install' fails with:

pkg-static: Unable to access file /usr/ports/x11-toolkits/gtk40/work/stage/usr/local/lib/gtk-4.0/4.0.0/printbackends/libprintbackend-cloudprint.so:No such file or directory
*** Error code 1

Also, 'make configure' shows the following warning:

WARNING: Unknown options: "cloudprint, cups"

The 'cloudprint' option is no longer available for 4.3.2 of course (and the option was spelled 'print-cloudprint' for 4.2.1 anyway).

The correct spelling for the cups option (for meson configuration) is 'print-cups'.  Because it is an 'auto' setting by default, it will detect and include cups support if found.  If cups is not installed, it will not build the cups print backend (but since there is a build dep for cups if the CUPS option is on, it was just luck that the misspelling did not matter).


The attached patch removes the CLOUDPRINT option and fixes the spelling of the cups configure on/off option for meson.
Comment 1 John Hein 2021-08-21 16:11:14 UTC
Committer CC'd
Comment 2 John Hein 2021-08-21 16:13:49 UTC
QA:
 poudriere testport (ok)
 portlint (ok, no new warnings - *DEPENDS could be moved earlier)
Comment 3 commit-hook freebsd_committer 2021-08-21 19:49:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f146095af5492ccd864bb7514a24650b1002b0a

commit 1f146095af5492ccd864bb7514a24650b1002b0a
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2021-08-21 19:44:16 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2021-08-21 19:48:13 +0000

    x11-toolkits/gtk40: remove CLOUDPRINT option; fix cups configure (+)

    * Cloudprint support was removed since gtk40 4.3.2
    * The correct spelling for the cups option (for meson configuration) is 'print-cups'.

    PR:             257986

 x11-toolkits/gtk40/Makefile  | 12 +++---------
 x11-toolkits/gtk40/pkg-plist |  1 -
 2 files changed, 3 insertions(+), 10 deletions(-)
Comment 4 Dima Panov freebsd_committer 2021-08-21 19:50:05 UTC
Committed, thanks!