Bug 258088

Summary: net-p2p/bazarr-devel: Update to 0.9.8-beta.11
Product: Ports & Packages Reporter: Michiel van Baak <michiel>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: diizzy, eduardo
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/morpheus65535/bazarr/releases/tag/v0.9.8-beta.11
Description Flags
michiel: maintainer-approval+
0001-net-p2p-bazarr-devel-Update-to-0.9.8-beta.11.patch michiel: maintainer-approval+

Description Michiel van Baak 2021-08-27 14:14:46 UTC
Created attachment 227476 [details]

Passes poudriere test.
Run-tested on freebsd13
Comment 1 Nuno Teixeira freebsd_committer 2021-08-27 14:49:44 UTC

1. portlint -C:
FATAL: Makefile: extra item "# Grab the asset as it contains built frontend and some extra files" placed in the PORTNAME section.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
Does this comment really needed?

2. we could order RUN_DEPENDS alphabetical:
+               ${PYTHON_PKGNAMEPREFIX}gevent-websocket>=0.10.1:www/py-gevent-websocket@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}gevent>=21:devel/py-gevent@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}lxml>=4.3.0:devel/py-lxml@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}lxml>=4.3.0:devel/py-lxml@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}webrtcvad>=2.0.10:audio/py-webrtcvad@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}gevent>=21:devel/py-gevent@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}gevent-websocket>=0.10.1:www/py-gevent-websocket@${PY_FLAVOR} \
                ffprobe:multimedia/ffmpeg \
Comment 2 Michiel van Baak 2021-08-27 15:08:14 UTC
(In reply to Nuno Teixeira from comment #1)
1. See following logs from libera.chat #freebsd-ports irc chat of today (I had the same question every single time I ask something about this port). This is why I put the comment in there:

16:53 <skered> It's a github based dist. so you can't make it a USE_GITHUB port?
16:56 <mvanbaak> no, it needs a compiled web frontend
16:56 <mvanbaak> npm/react/redux something something

2. Will do and update patch afterwards. Thanks for the feedback.
Comment 3 Michiel van Baak 2021-08-27 15:25:54 UTC
Created attachment 227477 [details]

Updated patch to sort RUN_DEPENDS as suggested
Comment 4 Daniel Engberg freebsd_committer 2021-09-07 20:19:08 UTC
Hi Michiel,

Can you please ask upstream to put version number in filenames as this causes issues in distfiles (I imagine that other distros have similar issues)?

To workaround this issue for now I'd suggest USE_GITHUB or wait until upstream releases a new version with version number.

Best regards,
Comment 5 Daniel Engberg freebsd_committer 2021-09-07 20:21:31 UTC
I missed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258088#c2 sorry for the noise but please try to pursue upstream ;-)
Comment 6 Michiel van Baak 2021-09-15 14:37:17 UTC
(In reply to Daniel Engberg from comment #5)

As you stated in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258476#c5 adding DIST_SUBDIR to both bazarr and bazarr-devel would also fix it. In a later comment there I also link and copy the reason why upstream wont create release assets with version number in the filename.

Also, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258511 is making this one obsolete.