Bug 258171
| Summary: | mail/mew: Prevent .el files from being native compiled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||
| Component: | Individual Port(s) | Assignee: | Yasuhiro Kimura <yasu> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | hiroto.kagotani, meta, ygy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(hiroto.kagotani) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Assign to submitter, and approved. Please take care of the same points I commented on Bug 258172. (In reply to Koichiro Iwao from comment #1) Different from bug #258172 I'm not maintainer of this port. So should I regard this bug report as approved by maintainer timeout? (In reply to Yasuhiro Kimura from comment #2) Indeed, maintainer's approval or timeout is required. My approval is only from committer's perspective. (In reply to Koichiro Iwao from comment #3) Then I need to add "Approved by:(tab)maintainer (timeout with 28days), meta (mentor)" to commit message. Correct? (In reply to Yasuhiro Kimura from comment #4) Yes. Include both in 'Approved by:' line. AFAIK, There's no clear format to show maintainer timeout but maybe the following two are preferred. > maintainer timeout (> 1 month) > maintainer timeout (maintainer@example.com, > 1 months) BTW, if maintainer timeout more than 3 months, MAINTAINER can be reset. So you can take such port in such case. https://www.freebsd.org/portmgr/policies_contributors/ A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8c8b03e3f12dadd1dbff03ab733929211ab4090d commit 8c8b03e3f12dadd1dbff03ab733929211ab4090d Author: Yasuhiro Kimura <yasu@FreeBSD.org> AuthorDate: 2021-08-30 10:47:56 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2021-09-28 08:20:18 +0000 mail/mew: Prevent .el files from being native compiled Mew doesn't work correctly if Emacs supports native compilation and .el files are compiled to .eln ones. So prevent .el files from being native compiled by adding following lines at the end of them. ;; Local Variables: ;; no-native-compile: t ;; End: PR: 258171 Approved by: maintainer timeout (> 28days), meta (mentor) mail/mew/Makefile | 2 +- mail/mew/files/patch-no-native-compile (new) | 863 +++++++++++++++++++++++++++ 2 files changed, 864 insertions(+), 1 deletion(-) |
Created attachment 227556 [details] Patch file Mew doesn't work correctly if Emacs supports native compilation and .el files are compiled to .eln ones. So prevent .el files from being native compiled by adding following lines at the end of them. ;; Local Variables: ;; no-native-compile: t ;; End: