Summary: | sysutils/zfs-stats update package description and WWW | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Graham Perrin <grahamperrin> | ||||||||||||||
Component: | Individual Port(s) | Assignee: | Joel Bodenmann <jbo> | ||||||||||||||
Status: | Closed FIXED | ||||||||||||||||
Severity: | Affects Some People | CC: | alster, grahamperrin, jbo, mm, zirias | ||||||||||||||
Priority: | --- | Flags: | jbo:
maintainer-feedback-
grahamperrin: maintainer-feedback? (mm) |
||||||||||||||
Version: | Latest | ||||||||||||||||
Hardware: | Any | ||||||||||||||||
OS: | Any | ||||||||||||||||
URL: | https://www.freshports.org/sysutils/zfs-stats/ | ||||||||||||||||
See Also: |
https://reviews.freebsd.org/D41835 https://github.com/grahamperrin/freebsd-ports/pull/3 https://github.com/mmatuska/zfs-stats/pull/8 |
||||||||||||||||
Attachments: |
|
Description
Graham Perrin
2021-09-03 05:36:58 UTC
Created attachment 243852 [details]
[PATCH 1/2] sysutils/zfs-stats: update description and WWW
Created attachment 243853 [details]
[PATCH 2/2] sysutils/zfs-stats: remove unneded shebangfix; was fixed in upstream
Created attachment 243860 [details]
[PATCH 1/2] sysutils/zfs-stats: Update pkg-descr and WWW
Created attachment 243861 [details]
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream
Created attachment 243898 [details]
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream
Maintainer timeout A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8ab46275a6c0f578c697bd9051559083a0d0306f commit 8ab46275a6c0f578c697bd9051559083a0d0306f Author: Andrey Korobkov <alster@vinterdalen.se> AuthorDate: 2023-09-12 16:03:25 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-09-12 20:45:24 +0000 sysutils/zfs-stats: Remove obsolete shebangfix and update pkg-descr While here, also cleanup some other port aspects. PR: 258238 Approved by: tcberner (mentor), mm (maintainer, timeout) Differential Revision: https://reviews.freebsd.org/D41835 sysutils/zfs-stats/Makefile | 14 ++++++-------- sysutils/zfs-stats/pkg-descr | 11 +++++++---- 2 files changed, 13 insertions(+), 12 deletions(-) Committed, thanks! <https://www.freshports.org/sysutils/zfs-stats/> <https://github.com/grahamperrin/freebsd-ports/pull/3.patch> for a signed-off patch file from the linked pull request (PR). ---- ^Triage, for this bug report Re: <https://bugs.freebsd.org/bugzilla/show_activity.cgi?id=258238>, mm@ will have lost sight of changes to this BR, so I'm flagging him for feedback with regard to the PR. @jbo if you prefer, make mm@ a CC recipient instead. ---- Generally, for the future, a gentle hint: * wherever a review in Phabricator will relate to a bug report in Bugzilla (and/or an issue or MR or PR in GitLab, GitHub or Codeberg), please make followers aware reasonably soon after review begins, certainly before completion of the review. Thanks :-) (In reply to Graham Perrin from comment #9) I can't decipher what you would like to see changed here. Please express it in simple and clear words instead of a pile of links of questionable relevance, thanks. Created attachment 245558 [details] signed-off patch file (In reply to Graham Perrin from comment #9) > See Also: … https://github.com/grahamperrin/freebsd-ports/pull/3 > Flags: maintainer-feedback?(mm@…) > <https://www.freshports.org/sysutils/zfs-stats/> > > <https://github.com/grahamperrin/freebsd-ports/pull/3.patch> for a > signed-off patch file from the linked pull request (PR). mm@ (maintainer, as shown in FreshPorts): the file now attached here in Bugzilla is for approval by you. File and commit message taken from the pull request. Discussed with Joel. @mm thank you. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c5fc53ebce498c84022f85b7357940dc3c9dafde commit c5fc53ebce498c84022f85b7357940dc3c9dafde Author: Graham Perrin <grahamperrin@gmail.com> AuthorDate: 2023-09-13 03:08:25 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-10-30 12:12:46 +0000 sysutils/zfs-stats: Update WWW Since we lost sight of the fact that this port is of a fork, it is no longer appropriate to use the original (non-fork) URL for WWW purposes. Instead, use the URL of the fork. PR: 258238 Approved by: zirias (mentor), mm (maintainer, timeout) Differential Revision: https://reviews.freebsd.org/D42397 sysutils/zfs-stats/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) WWW updated - Thanks Graham Perrin. |