Summary: | devel/kf5-kio: incomplete dependency on devel/kf5-kdoctools | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | randombit <randombit> |
Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> |
Status: | Closed FIXED | ||
Severity: | Affects Many People | CC: | adridg, arrowd, tcberner |
Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
Version: | Latest | ||
Hardware: | amd64 | ||
OS: | Any |
Description
randombit
2021-09-03 19:23:26 UTC
Moin moin Indeed it looks like the dependency on doctools was made build-only by mistake in devel/kf5-kio: ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/libKF5KIOFileWidgets.so.5.85.0 is linked to /usr/local/lib/libKF5GuiAddons.so.5 from x11-toolkits/kf5-kguiaddons but it is not declared as a dependency Warning: you need USE_KDE+=guiaddons Error: /usr/local/lib/qt5/plugins/kf5/kio/kio_ghelp.so is linked to /usr/local/lib/libKF5DocTools.so.5 from devel/kf5-kdoctools but it is not declared as a dependency Warning: you need USE_KDE+=doctools mfg Tobias diff --git a/devel/kf5-kio/Makefile b/devel/kf5-kio/Makefile index e9e30041beef..b42f0973c02b 100644 --- a/devel/kf5-kio/Makefile +++ b/devel/kf5-kio/Makefile @@ -1,5 +1,6 @@ PORTNAME= kio DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= devel kde kde-frameworks MAINTAINER= kde@FreeBSD.org @@ -9,11 +10,11 @@ USES= cmake compiler:c++11-lib desktop-file-utils \ gettext gnome kde:5 qt:5 ssl tar:xz USE_GNOME= libxml2 libxslt USE_KDE= archive auth bookmarks codecs completion config \ - configwidgets coreaddons crash dbusaddons \ + configwidgets coreaddons crash dbusaddons guiaddons \ i18n iconthemes itemviews jobwidgets kded \ notifications service solid sonnet textwidgets wallet \ widgetsaddons windowsystem xmlgui \ - doctools_build ecm_build + doctools ecm_build USE_QT= concurrent core dbus declarative gui network \ script widgets x11extras xml \ buildtools_build qmake_build testlib_build OK to push? I'd really rather not; guiaddons is fine, but doctools is **fat** because it pulls in .. all the documentation tooling. One reason I went through pushing doctools to `_build` all over was to avoid those 60MB for everything that could possibly use kio. That's mostly important for "live CD" situations like helloSystem, though. If we could have subpackages, this would be a no-brainer: put the help: and ghelp: KIO workers in a subpackage which pulls in the doctools. They are of limited use (in the sense that without the help: worker, application help falls back to a web browser pointing at docs.kde.org rather than a local copy). A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2c0f38fb85951f5fa0280353d4342f95f5c55c5c commit 2c0f38fb85951f5fa0280353d4342f95f5c55c5c Author: Gleb Popov <arrowd@FreeBSD.org> AuthorDate: 2021-09-19 07:49:29 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2021-09-19 07:50:38 +0000 devel/kf5-kio: Add missing dependency on x11-toolkits/kf5-kguiaddons PR: 258259 Approved by: adridg devel/kf5-kio/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Should we close this PR for now? |