Bug 258292

Summary: mail/neomutt: Respect CC
Product: Ports & Packages Reporter: Evgenii Khramtsov <2khramtsov>
Component: Individual Port(s)Assignee: Baptiste Daroussin <bapt>
Status: Closed FIXED    
Severity: Affects Some People Keywords: needs-qa
Priority: --- Flags: 2khramtsov: maintainer-feedback-
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 (use "git am") none

Description Evgenii Khramtsov 2021-09-05 18:25:00 UTC 
Created attachment 227692 [details]
v1 (use "git am")

mail/neomutt needs to respect CC per https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-cc

Reproduce by deleting 'cc' from jail and overriding CC to another value.

Package contents did not change:

11.4/amd64: https://codeberg.org/ei/misc/commit/eb085f3ba60
11.4/i386:  https://codeberg.org/ei/misc/commit/4ad3ffef396
12.2/amd64: https://codeberg.org/ei/misc/commit/b16c45d9963
12.2/i386:  https://codeberg.org/ei/misc/commit/e1f88aff135
13.0/amd64: https://codeberg.org/ei/misc/commit/6629ac89ec6

Log diff with the patch applied:

11.4/amd64: https://codeberg.org/ei/misc/commit/3b4159a7192
11.4/i386:  https://codeberg.org/ei/misc/commit/c8392642678
12.2/amd64: https://codeberg.org/ei/misc/commit/726ed7004ab
12.2/i386:  https://codeberg.org/ei/misc/commit/9c311e55600
13.0/amd64: https://codeberg.org/ei/misc/commit/7a161f0037f

Testport logs with the patch applied:

11.4/amd64: https://codeberg.org/ei/misc/commit/8a30ca1a975
11.4/i386:  https://codeberg.org/ei/misc/commit/dd7e0c22d3e
12.2/amd64: https://codeberg.org/ei/misc/commit/3284b358fb9
12.2/i386:  https://codeberg.org/ei/misc/commit/82572f8dd21
13.0/amd64: https://codeberg.org/ei/misc/commit/6724a3cf900

13.0/aarch64 QA via qemu-user-static is omitted because the
dependency 'mail/notmuch' can't configure here, maybe a bug?
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-06 02:51:41 UTC 
Are environment/user CFLAGS and other flags (LDFLAGS, etc) honoured? Honoured meaning 'appended', not just included
Comment 2 Evgenii Khramtsov 2021-09-06 11:10:36 UTC 
(In reply to Kubilay Kocak from comment #1)

Yes. Checked via "Summary of build options" and build commands from build log:
---Begin make.conf---
[...]
#### /usr/local/etc/poudriere.d/130-amd64-make.conf ####
CFLAGS+=-O0
LDFLAGS+=-Wl,--as-needed
[...]

-CFlags:                -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -std=c99 -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -I/usr/local/include -DNCURSES_WIDECHAR -I/usr/include -I/usr/include
-CFlags:                -O2 -pipe -O0  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -std=c99 -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -I/usr/local/include -DNCURSES_WIDECHAR -I/usr/include -I/usr/include
-LDFlags:                -fstack-protector-strong  -L/usr/local/lib -L/usr/lib -L/usr/lib -lgssapi -lgssapi_krb5 -lheimntlm -lkrb5 -lhx509 -lcom_err -lcrypto -lasn1 -lwind -lheimbase -lroken -lcrypt -pthread
+LDFlags:                -Wl,--as-needed  -fstack-protector-strong  -L/usr/local/lib -L/usr/lib -L/usr/lib -lgssapi -lgssapi_krb5 -lheimntlm -lkrb5 -lhx509 -lcom_err -lcrypto -lasn1 -lwind -lheimbase -lroken -lcrypt -pthread

> needs-qa

Can you clarify what QA does this change need? This port does not have consumers
and I already did QA on Tier 1 platforms and made sure that the package contents did not change. "CC_FOR_BUILD" is also used by many ports, e.g. ports-mgmt/pkg.
Comment 3 Evgenii Khramtsov 2021-09-21 15:01:03 UTC 
Maintainer timeout.
Comment 4 Evgenii Khramtsov 2021-10-03 13:47:42 UTC 
Ping.
Comment 5 Evgenii Khramtsov 2021-10-23 17:02:50 UTC 
ping
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-01-17 15:51:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=735d210819c11c4db5fc544106bc24c0ebaa2094

commit 735d210819c11c4db5fc544106bc24c0ebaa2094
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-09-03 12:13:08 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-01-17 15:49:43 +0000

    mail/neomutt: respect CC

    PR:     258292

 mail/neomutt/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Baptiste Daroussin freebsd_committer freebsd_triage 2022-01-17 15:59:23 UTC 
sorry it took so long