Bug 258371

Summary: net-im/libsignal-client: drop or limit RUSTC_BOOTSTRAP
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Only Me CC: mikael
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (0mp)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v0 none

Description Jan Beich freebsd_committer freebsd_triage 2021-09-08 15:45:13 UTC 
Created attachment 227768 [details]
v0

After ports 6bebfaa8a06c RUSTC_BOOTSTRAP=1 can be limited to RUSTC_BOOTSTRAP=<crate>,<crate>,... See https://github.com/rust-lang/rust/pull/77802. However, this port appears to build fine without any RUSTC_BOOTSTRAP. Is it still necessary e.g., for some runtime features?

Disclaimer: I don't use this port.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-10-05 08:57:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=491afce55b3b516ed0d238997d53de2aad2d9766

commit 491afce55b3b516ed0d238997d53de2aad2d9766
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2021-10-05 08:54:01 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-05 08:57:13 +0000

    net-im/libsignal-client: Clean up USES=cargo variables

    - Remove unnecessary CARGO_INSTALL=no
    - Drop RUST_BOOTSTRAP [1]

    PR:             258371 [1]
    Reported by:    jbeich [1]

 net-im/libsignal-client/Makefile | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-05 08:59:14 UTC 
The port builds just fine without rust-nightly. Thanks!
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2021-10-13 12:00:29 UTC 
(In reply to Mateusz Piotrowski from comment #2)
This breaks on aarch64:
error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/net-im/libsignal-client/work/libsignal-client-0.9.6/cargo-crates/polyval-0.5.1/src/lib.rs:80:5
80 |     feature(stdsimd, aarch64_target_feature)

--> /usr/ports/net-im/libsignal-client/work/libsignal-client-0.9.6/cargo-crates/aes-0.7.4/src/lib.rs:87:5
7 |     feature(stdsimd, aarch64_target_feature)


fixed with:
--- a/net-im/libsignal-client/Makefile
+++ b/net-im/libsignal-client/Makefile
@@ -238,7 +238,8 @@ CARGO_USE_GITHUB=   yes
 CARGO_BUILD_ARGS=      --package libsignal-jni
 MAKE_ENV=              CARGO_PROFILE_RELEASE_LTO=thin \
                        OPENSSL_INCLUDE_DIR=${OPENSSLINC} \
-                       OPENSSL_LIB_DIR=${OPENSSLLIB}
+                       OPENSSL_LIB_DIR=${OPENSSLLIB} \
+                       RUSTC_BOOTSTRAP=aes,polyval
 PLIST_FILES=           lib/libsignal_jni.so
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-13 12:25:20 UTC 
(In reply to Mikael Urankar from comment #3)

Feel free to commit the necessary fixes! I cannot really test on ARM now.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-13 14:35:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=70d9cc0d84a230e1ec7aa65d0386d0834a914b15

commit 70d9cc0d84a230e1ec7aa65d0386d0834a914b15
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2021-10-13 14:30:00 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-10-13 14:30:00 +0000

    net-im/libsignal-client: Fix build on aarch64

    aarch64 still uses unstable features:
    error[E0554]: `#![feature]` may not be used on the stable release channel
      --> /usr/ports/net-im/libsignal-client/work/libsignal-client-0.9.6/cargo-crates/polyval-0.5.1/src/lib.rs:80:5
    80 |     feature(stdsimd, aarch64_target_feature)

    --> /usr/ports/net-im/libsignal-client/work/libsignal-client-0.9.6/cargo-crates/aes-0.7.4/src/lib.rs:87:5
    7 |     feature(stdsimd, aarch64_target_feature)

    PR:             258371
    Approved by:    0mp (maintainer)

 net-im/libsignal-client/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)