Summary: | devel/simdjson: update to 1.0.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Oleg Ginzburg <olevole> | ||||
Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | diizzy, eduardo, thierry, yuri | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://github.com/simdjson/simdjson/releases/tag/v1.0.0 | ||||||
Attachments: |
|
Description
Oleg Ginzburg
2021-09-08 19:16:18 UTC
Hello, 1. Makefile says: --- BROKEN_i386= does not build (error: unknown type name '__uint128_t') --- Poudriere tests at https://people.freebsd.org/~eduardo/logs/simdjson-1.0.0/ compiles ok on i386 with a warning: --- warning: The simdjson library is designed for 64-bit processors and it seems that you are not compiling for a known 64-bit platform. All fast kernels will be disabled and performance may be poor. Please use a 64-bit target such as x64, 64-bit ARM or 64-bit PPC. [-W#pragma-messages] --- Maybe upstream have done some compatibily with i386? 2. Small order fix (from portclippy): Move "CXXFLAGS_powerpc64" to CFLAGS/CXXFLAGS/LDFLAGS block: --- # PORTNAME block PORTNAME DISTVERSIONPREFIX DISTVERSION CATEGORIES # Maintainer block MAINTAINER COMMENT # License block LICENSE LICENSE_FILE # BROKEN/IGNORE/DEPRECATED messages BROKEN_i386 -CXXFLAGS_powerpc64 <== # USES block USES USE_GITHUB USE_LDCONFIG # USES=cmake related variables CMAKE_ON # CFLAGS/CXXFLAGS/LDFLAGS block +CXXFLAGS_powerpc64 <== --- Could you test this on i386? Hi Oleg, Are there any noticable improvements building this port with -O3? https://github.com/simdjson/simdjson#performance-results Is it possible to enable unit tests? Best regards, Daniel Friendly ping Note that version 2.0.1 was released on May 26th: https://github.com/simdjson/simdjson/releases/tag/v2.0.1 Updated to 2.2.0 A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=427feae70d7065b9083c73a3fb139bc11efb7a3a commit 427feae70d7065b9083c73a3fb139bc11efb7a3a Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2022-07-13 04:59:34 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-07-13 05:01:04 +0000 devel/simdjson: Update 0.9.6 -> 2.2.0 PR: 258373 Approved by: olevole@olevole.ru (maintainer's timeout; 10 months) devel/simdjson/Makefile | 7 +++++-- devel/simdjson/distinfo | 6 +++--- ...tch-include_simdjson_ppc64_numberparsing.h (gone) | 20 -------------------- devel/simdjson/pkg-plist | 8 ++++---- 4 files changed, 12 insertions(+), 29 deletions(-) |