Summary: | net-p2p/bazarr: Update to 0.9.9 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Michiel van Baak Jansen <michiel> | ||||||||
Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | diizzy, eduardo | ||||||||
Priority: | --- | ||||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
URL: | https://github.com/morpheus65535/bazarr/releases/tag/v0.9.9 | ||||||||||
Attachments: |
|
Hello, 'portlint -C': --- FATAL: Makefile: extra item "# Grab the asset as it contains built frontend and some extra files" placed in the PORTNAME section. 1 fatal error and 0 warnings found. --- Is it really necessary this comment to download distfile? (In reply to Nuno Teixeira from comment #1) Sure I can remove it, but then on next update there will be a review comment asking why it uses a distfile. That's the reason why I put it there in the first place. Created attachment 227892 [details]
0001-net-p2p-bazarr-Update-to-0.9.9.patch
Same as before, but with the comment line removed from the Makefile.
(In reply to Michiel van Baak from comment #2) You are using the correct way to fetch distfile: --- 5.4.3. USE_GITHUB If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file, there is an easy way to set the right DISTNAME and MASTER_SITES automatically. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-distfiles --- In this particular case, upstream have an static distfile realease available and it should be used with MASTER_SITES. If upstream don't have an static release available, then we need to use USE_GITHUB to fetch a dynamic auto generated distfile. In this case (unless we can pursue upstream to version files which would be the best solution) it might be an idea to set DIST_SUBDIR to something like ${PORTNAME}/${DISTVERSION} for both ports to allow distfile(s) to co-exist. (In reply to Daniel Engberg from comment #5) Hello Daniel, Could you please take this PR so I can learn more how to do this? (In reply to Daniel Engberg from comment #5) I asked upstream about putting the version in the asset (using a pr, see https://github.com/morpheus65535/bazarr/pull/1545) They will not do this for the following reason (They replied on the pr, put here so people dont have to go to github): "I won't merge this one as the Bazarr Windows installer rely on having always the same asset name to properly get the latest one." They are depending on the fact github provides a 'latest' version specifier pointing to the latest stable release: https://github.com/morpheus65535/bazarr/releases/latest/download/bazarr.zip I'll add the DIST_SUBDIR to the Makefile Thanks for your patience Created attachment 227913 [details]
0001-net-p2p-bazarr-Update-to-0.9.9.patch
Added DIST_SUBDIR
Added DIST_SUBDIR (and updated to latest beta) to bazarr-devel in PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258511 Sorry that at first I didn't see what was the problem here. I've looked at bazarr-devel and it make all sense to use DIST_SUBDIR. Just doing some tests A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a351de4b7b6229238f79199c213a8b40512b39c8 commit a351de4b7b6229238f79199c213a8b40512b39c8 Author: Michiel van Baak <michiel@vanbaak.eu> AuthorDate: 2021-09-16 09:21:23 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-09-16 09:25:35 +0000 net-p2p/bazarr: Update to 0.9.9 - add DIST_SUBDIR so bazarr and bazarr-devel distfiles can coexist ChangeLog: https://github.com/morpheus65535/bazarr/releases/tag/v0.9.9 PR: 258476 net-p2p/bazarr/Makefile | 10 +++++----- net-p2p/bazarr/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) Committed thanks! (In reply to Daniel Engberg from comment #5) Thank you Daniel for your help. Cheers (In reply to Nuno Teixeira from comment #13) You're welcome! Sorry about not responding to your request earlier, it drowned in my pile of mail :/ (In reply to Daniel Engberg from comment #14) And thank you both for getting this one (and the bazarr-devel) in. |
Created attachment 227872 [details] 0001-net-p2p-bazarr-Update-to-0.9.9.patch Runs 'in production' on my setup (13.0-RELEASE-p3 on AMD64). Passes poudriere tests.