Bug 258480

Summary: audio/zita-jclient: remove march=native
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy
Priority: --- Flags: bugzilla: maintainer-feedback? (yuri)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v0 none

Description Mikael Urankar freebsd_committer freebsd_triage 2021-09-13 15:41:40 UTC
Created attachment 227877 [details]
v0

-march=native isn't valid on !x86 arches, it causes build failure.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-09-13 16:00:20 UTC
Shouldn't we also drop -O2 as per Porters Handbook or does it get overridden?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-09-13 17:26:03 UTC
Thanks for the patch.

I am committing a similar patch which has march=native conditional on the NATIVE option. Also removing -O2 which otherwise did stay in the compilation command line,
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-09-13 17:26:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=129d59283ffa0881ecb4e105e7d4a229152218fe

commit 129d59283ffa0881ecb4e105e7d4a229152218fe
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-09-13 17:20:46 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-09-13 17:25:03 +0000

    audio/zita-jclient: Make march=native conditional on the new option NATIVE, and remove -O2

    PR:             258480
    Reported by:    mikael (submitted original patch)

 audio/zita-jclient/Makefile             |  7 ++++++-
 audio/zita-jclient/files/patch-Makefile | 13 ++++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)