Bug 258502
| Summary: | [exp-run] drop INSTALLS_ICONS in favour of triggers | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Baptiste Daroussin <bapt> |
| Component: | Ports Framework | Assignee: | Baptiste Daroussin <bapt> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | ports-bugs |
| Priority: | --- | Flags: | antoine:
exp-run+
|
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| URL: | https://reviews.freebsd.org/D31960 | ||
|
Description
Baptiste Daroussin
2021-09-14 15:38:49 UTC
There is a new leftover in a lot of ports: =>> Checking for extra files and directories =>> Error: Files or directories left over: share/icons/hicolor/icon-theme.cache I don't know if it's an issue in a port or if Mk/Scripts/check_leftovers.sh has to be updated? Nope, it needs more work from the trigger point of view. I'll ping you when I have fixed the issue done, I have update to diff in the review! Note: it requires pkg 1.17.2! Around 80 ports left over a share/icons directory on uninstall: http://package23.nyi.freebsd.org/data/114i386-default-foo/2021-09-23_09h22m41s/logs/errors/adwaita-icon-theme-40.1.1.log http://package23.nyi.freebsd.org/data/114i386-default-foo/2021-09-23_09h22m41s/logs/errors/gnome-icon-theme-symbolic-3.12.0.log http://package23.nyi.freebsd.org/data/114i386-default-foo/2021-09-23_09h22m41s/logs/errors/djvulibre-3.5.28.log etc. This issue should imho be fixed by adding share/icons to the default mtree I will do that. done, imho it would be worth another run (In reply to Baptiste Daroussin from comment #6) f This does not fix the leftover directory. (I am not sure that the mtree file is still used in packages after auto-directory removal) really fixed this time (the patch has been updated in phabricator) Exp-run looks fine A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=46bcb098c82f7a18c7667fc99f6a7824b2b6eeef commit 46bcb098c82f7a18c7667fc99f6a7824b2b6eeef Author: Baptiste Daroussin <bapt@FreeBSD.org> AuthorDate: 2021-09-14 15:24:59 +0000 Commit: Baptiste Daroussin <bapt@FreeBSD.org> CommitDate: 2021-10-10 17:46:46 +0000 graphics/gtk-update-icon-cache: use triggers Use triggers instead of enforcing the INSTALL_ICONS which enforces gtk-update-icon-cache dependency on every ports installing icons. The bonus: - factorize gtk-update-icon-cache update at the end of the build - stop adding a gratuicious dependency on gtk-update-icon-cache on packages which do not need it - works on packages where INSTALLS_ICONS were forgotten PR: 258502 Exp-run: antoine Reviewed by: tcberner Differential Revision: https://reviews.freebsd.org/D31960 graphics/gtk-update-icon-cache/Makefile | 3 ++- .../files/gtk-update-icon-cache.ucl.in (new) | 30 ++++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) |