Bug 258565

Summary: security/clamav: Update to 0.104.0
Product: Ports & Packages Reporter: Yasuhiro Kimura <yasu>
Component: Individual Port(s)Assignee: Yasuhiro Kimura <yasu>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, eduardo, meta, ygy
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://blog.clamav.net/2021/09/clamav-01040-released.html
Attachments:
Description Flags
Patch file
yasu: maintainer-approval+
Updated patch file yasu: maintainer-approval+

Description Yasuhiro Kimura freebsd_committer freebsd_triage 2021-09-18 06:57:25 UTC 
Created attachment 227970 [details]
Patch file

* Update to 0.104.0.
* Update COMMENT and pkg-descr.

Release Notes: https://blog.clamav.net/2021/09/clamav-01040-released.html
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-09-18 10:37:57 UTC 
Created attachment 227976 [details]
Updated patch file

* Add "(Regular (non-LTS) version)" to COMMENT to make it clear this is non-LTS version compared with upcoming security/clamav-lts.
* Pet portclippy
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2021-09-29 09:06:33 UTC 
Assign to submitter since submitter is now commiitter.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-09-29 13:09:30 UTC 
Looks good!

A few suggestions on improvements

Do we still need INSTALL_TARGET?

Instead of the OPT_CMAKE_ON/OFF doesn't OPT_CMAKE_BOOL work?
https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool

MILTER_CFLAGS/LDFLAGS --> USES= localbase
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

L68 (new patch) MILTER should probably be better defined rather than "if exists" (base vs port)
L69 --> += should be =

L80 should probably be python:3.6+,test (unless 2.X still works)
https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n38

118 --> TEST_TARGET= check ?

You might want to put docs path in lowercase for consistency

Best regards,
Daniel
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-10-29 22:52:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=11ce5b3d719c4e44114f0557144a3a773cabfcfd

commit 11ce5b3d719c4e44114f0557144a3a773cabfcfd
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2021-09-18 05:27:42 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-10-29 22:52:24 +0000

    security/clamav: Update to 0.104.0

    * Upstream changed build tool from GNU Autotools to CMake
    * Set TEST_TARGET
    * Add pre-test-TESTS-off target to display message that TESTS option
      needs to be enabled to execute `make test`
    * Switch to use pkg-messge instead of pkg-deinstall to display message
      for those who removes ClamAV permanently from you system
    * Stop checking in rc scripts if /var/run/clamav exists
    * Pet portclippy
    * Reformat Makefile with portfmt

    Release Notes:  https://blog.clamav.net/2021/09/clamav-01040-released.html
    PR:             258565
    Differential Revision:  https://reviews.freebsd.org/D32354

 security/clamav/Makefile                           | 206 ++++++++-------------
 security/clamav/distinfo                           |   6 +-
 security/clamav/files/clamav-clamd.in              |   7 +-
 security/clamav/files/clamav-freshclam.in          |  11 --
 ...shared_output.c => extra-patch-common_output.c} |   4 +-
 ...amav_c++_llvm_include_llvm_Support_CFG.h (gone) |  62 -------
 security/clamav/files/pkg-deinstall.in (gone)      |  25 ---
 security/clamav/files/pkg-message.in (new)         |  13 ++
 security/clamav/pkg-plist                          | 165 +++++++++++++----
 9 files changed, 224 insertions(+), 275 deletions(-)