Bug 258632

Summary: misc/mc: X11 is not properly unset when disabled
Product: Ports & Packages Reporter: Michael Osipov <michael.osipov>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Some People CC: michael.osipov
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
Version: Latest   
Hardware: Any   
OS: Any   

Description Michael Osipov 2021-09-20 14:44:10 UTC
The Makfile like 69 configures:

This is, unfortunately, useless because the configure script says: --with-x.
Therefore, the Makefile passes --enable-x/--disable-x which remains without any effect. X will be autodetected even if you have (pseudo-)disabled it.

The fix is simple and works for me:

and that's it.

I have reported the same for vim in Bug 258407.

Without this fix and X11 explicitly disabled PuTTY session still tells me:
> PuTTY X11 proxy: unable to connect to forwarded X server: Network error: Connection refused
Comment 1 commit-hook freebsd_committer 2021-09-22 06:33:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d37893d25e54a580b0c7f9ceaef3f6a3814815da

commit d37893d25e54a580b0c7f9ceaef3f6a3814815da
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-09-22 06:26:32 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-09-22 06:29:22 +0000

    misc/mc: handling of the port's options had been improved (+)

    - Use correct helper for X11 option, which is --with-x, not --enable-x
    - Do not pass bogus --without-smb-foobar=... options when SMB support
      is disabled
    - Allow to build with Aspell support in the internal editor while here

    PR:     258632

 misc/mc/Makefile | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer 2021-09-22 06:41:47 UTC
Committed with a couple of other options handling improvements, thank you!
Comment 3 Michael Osipov 2021-09-22 09:20:49 UTC
(In reply to Alexey Dokuchaev from comment #2)

Спасибо тебе Леша!