Bug 258635

Summary: Every portsnap fetch update get textproc/*-mythes, textproc/*-hyphen, */hyphen and */mythes ports
Product: Services Reporter: Vladimir Druzenko <vvd>
Component: PortsnapAssignee: Colin Percival <cperciva>
Status: Closed FIXED    
Severity: Affects Some People CC: fluffy, henk, ports-secteam, sunpoet
Priority: ---    
Version: unspecified   
Hardware: amd64   
OS: Any   

Description Vladimir Druzenko freebsd_committer freebsd_triage 2021-09-20 18:04:54 UTC 
12.2 amd64.

Every time I run "portsnap fetch update" I get updates for all ports textproc/*-mythes, textproc/*-hyphen, */hyphen and */mythes if any other port was updated:

# portsnap fetch update
Looking up portsnap.FreeBSD.org mirrors... 4 mirrors found.
Fetching snapshot tag from ipv4.aws.portsnap.freebsd.org... done.
Fetching snapshot metadata... done.
Updating from Mon Sep 20 19:44:27 MSK 2021 to Mon Sep 20 20:18:51 MSK 2021.
Fetching 1 metadata patches. done.
Applying metadata patches... done.
Fetching 0 metadata files... done.
Fetching 35 patches. 
(35/35) 100.00%  done.                               
done.
Applying patches... 
done.
Fetching 0 new ports or files... done.
Removing old files and directories... done.
Extracting new files:
/usr/ports/french/mythes/
/usr/ports/german/hyphen/
/usr/ports/hungarian/hyphen/
/usr/ports/hungarian/mythes/
/usr/ports/polish/hyphen/
/usr/ports/polish/mythes/
/usr/ports/portuguese/hyphen/
/usr/ports/portuguese/mythes/
/usr/ports/russian/hyphen/
/usr/ports/russian/mythes/
/usr/ports/textproc/bg-hyphen/
/usr/ports/textproc/bg-mythes/
/usr/ports/textproc/cs-hyphen/
/usr/ports/textproc/cs-mythes/
/usr/ports/textproc/el-hyphen/
/usr/ports/textproc/en-mythes/
/usr/ports/textproc/es-hyphen/
/usr/ports/textproc/es-mythes/
/usr/ports/textproc/hyphen/
/usr/ports/textproc/id-hyphen/
/usr/ports/textproc/is-hyphen/
/usr/ports/textproc/it-hyphen/
/usr/ports/textproc/it-mythes/
/usr/ports/textproc/lt-hyphen/
/usr/ports/textproc/nl-hyphen/
/usr/ports/textproc/nl-mythes/
/usr/ports/textproc/ro-hyphen/
/usr/ports/textproc/ro-mythes/
/usr/ports/textproc/sk-hyphen/
/usr/ports/textproc/sk-mythes/
/usr/ports/textproc/sl-hyphen/
/usr/ports/textproc/sl-mythes/
/usr/ports/textproc/sv-mythes/
/usr/ports/ukrainian/hyphen/
/usr/ports/ukrainian/mythes/
Building new INDEX files... done.

This issue is same on 2 different hosts.
Removed /var/db/portsnap/* didn't help.
This behavior started yesterday or the day before yesterday.
Comment 1 Henk Miltenburg 2021-09-20 20:06:52 UTC 
I experienced the same problem. I found that each folder contains two makefiles. One with the name Makefile and another with the same name with a trailing space. Maybe this helps.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2021-09-20 20:27:59 UTC 
Pointy hat to @sunpoet :( 

His games with "Avoid using %% in Makefile Use ${DATAIDR} instead of %%DATADIR%%" leads to this result :( 

https://cgit.FreeBSD.org/ports/commit/?id=915dbfaa562e20c8402d3873f8bfbf07899f9f8a
https://cgit.FreeBSD.org/ports/commit/?id=72664fc2b4d33ca3ae39c8e7ab6f8fa85c08bd63
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-09-21 04:05:00 UTC 
I removed the unintended backup files ("Makefile ") in 7774ccb4f56cfb8e4713455242e644d968a5e2ad and 63b6f938109571011e834d4f1e97c248c1919102.

I made in-place replacement with sed -i '' but somehow an unintended space was added.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2021-09-21 14:19:41 UTC 
Fixed for me.