Bug 258942

Summary: www/trac-devel: Incompatible with Jinja2 >= 3.0.0
Product: Ports & Packages Reporter: Lapo Luchini <lapo>
Component: Individual Port(s)Assignee: Oleksii Samorukov <samm>
Status: Closed FIXED    
Severity: Affects Many People CC: david, nivit, python
Priority: --- Keywords: regression
Version: LatestFlags: bugzilla: maintainer-feedback? (samm)
koobs: maintainer-feedback? (nivit)
koobs: merge-quarterly+
Hardware: Any   
OS: Any   
URL: https://trac.edgewall.org/ticket/13404
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255923

Description Lapo Luchini 2021-10-05 10:31:12 UTC 
% sudo service tracd start
ImportError: cannot import name 'soft_unicode' from 'jinja2.utils' (/usr/local/lib/python3.8/site-packages/jinja2/utils.py)

Known upstream as issue 13404, with no work-around so far (the one in the ticket is regarding a different error):
https://trac.edgewall.org/ticket/13404
Comment 1 Lapo Luchini 2021-10-05 10:47:45 UTC 
Oh, I didn't notice the solution was already in the question:

DeprecationWarning: 'jinja2.utils.soft_unicode' will be removed in version 3.0. Use 'markupsafe.soft_unicode' instead.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-06 00:09:16 UTC 
^Triage: Broken by ports 04ca9b0f4970d8d47accc9e31ef0c91b1a9d01f0 request feedback from committer

Upstream commit addressing issue: https://trac.edgewall.org/changeset/17543

Does trace have a test suite shipped with their distribution files that we can add as a port test target to improve future QA?
Comment 3 Oleksii Samorukov freebsd_committer freebsd_triage 2021-11-24 19:58:10 UTC 
I will update trac now and integrate upstream patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-11-24 20:27:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=29c0aa77578b766ac518e948c76834869e9813e5

commit 29c0aa77578b766ac518e948c76834869e9813e5
Author:     Oleksii Samorukov <samm@FreeBSD.org>
AuthorDate: 2021-11-24 20:22:39 +0000
Commit:     Oleksii Samorukov <samm@FreeBSD.org>
CommitDate: 2021-11-24 20:22:39 +0000

    www/trac-devel: Upgrade to 1.5.3 and unbreak

    PR:             258942
    Reported by:    lapo@lapo.it

 www/trac-devel/Makefile                            |  4 +--
 www/trac-devel/distinfo                            |  6 ++---
 ...h-trac_ticket_templates_report__view.html (new) | 10 +++++++
 www/trac-devel/files/patch-trac_util_html.py (new) | 11 ++++++++
 .../files/patch-trac_util_presentation.py (new)    | 19 +++++++++++++
 www/trac-devel/files/patch-trac_util_text.py (new) | 31 ++++++++++++++++++++++
 6 files changed, 75 insertions(+), 6 deletions(-)
Comment 5 Oleksii Samorukov freebsd_committer freebsd_triage 2021-11-24 20:31:08 UTC 
*** Bug 259910 has been marked as a duplicate of this bug. ***
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-25 23:42:07 UTC 
(In reply to commit-hook from comment #4)

Is quarterly also broken Oleksii? If so, could you please merge the minimum necessary changeset to resolve in quarterly.
Comment 7 Oleksii Samorukov freebsd_committer freebsd_triage 2021-11-26 08:30:07 UTC 
Merging to quarterly
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-11-28 11:14:28 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebd032c40d75315cbc797299cca88c78c381d7e4

commit ebd032c40d75315cbc797299cca88c78c381d7e4
Author:     Oleksii Samorukov <samm@FreeBSD.org>
AuthorDate: 2021-11-25 09:02:48 +0000
Commit:     Oleksii Samorukov <samm@FreeBSD.org>
CommitDate: 2021-11-28 11:12:03 +0000

    www/trac-devel: remove outdated patch

    Reported by: pkg-fallout@FreeBSD.org
    PR:             258942
    MFH:            2021Q4

    (cherry picked from commit 33c764690e3e249e2c6481fd1ec8d26e14845e78)

 .../files/patch-trac_util_daemon.py (gone)         | 23 ----------------------
 1 file changed, 23 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-11-28 11:14:30 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ee0d4c8e33986ebee2a89b321285288ca7a9ff8

commit 0ee0d4c8e33986ebee2a89b321285288ca7a9ff8
Author:     Oleksii Samorukov <samm@FreeBSD.org>
AuthorDate: 2021-11-24 20:22:39 +0000
Commit:     Oleksii Samorukov <samm@FreeBSD.org>
CommitDate: 2021-11-28 11:13:18 +0000

    www/trac-devel: Upgrade to 1.5.3 and unbreak

    Reported by: pkg-fallout@FreeBSD.org
    PR:             258942
    MFH:            2021Q$

    (cherry picked from commit 29c0aa77578b766ac518e948c76834869e9813e5)

 www/trac-devel/Makefile                            |  2 +-
 www/trac-devel/distinfo                            |  6 ++---
 ...h-trac_ticket_templates_report__view.html (new) | 10 +++++++
 www/trac-devel/files/patch-trac_util_html.py (new) | 11 ++++++++
 .../files/patch-trac_util_presentation.py (new)    | 19 +++++++++++++
 www/trac-devel/files/patch-trac_util_text.py (new) | 31 ++++++++++++++++++++++
 6 files changed, 75 insertions(+), 4 deletions(-)
Comment 10 Oleksii Samorukov freebsd_committer freebsd_triage 2021-11-28 11:15:51 UTC 
Changes merged to 2021Q4
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-30 00:59:27 UTC 
(In reply to Oleksii Samorukov from comment #10)

Much appreciated Oleksii!