Bug 259061
| Summary: | devel/py-apispec: Update to 5.1.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Goran Mekić <meka> | ||||||||
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | eduardo | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://github.com/marshmallow-code/apispec/blob/dev/CHANGELOG.rst#511-2021-09-27 | ||||||||||
| Attachments: |
|
||||||||||
Hello, diff shows that you are downgrading from 5.1.1 -> 5.1.0 Please correct diff Created attachment 228579 [details]
apispec.diff
I'm sorry, I switched argument places when generating git diff. Thank you!
Hello,
just a minor fix in TEST_DEPENDS lists, alphabetical order (portfmt -D Makefile):
---
--- Makefile
+++ Makefile
@@ -10,14 +10,14 @@
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE
+TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}marshmallow>0:devel/py-marshmallow@${PY_FLAVOR} \
+ ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR} \
-TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml@${PY_FLAVOR} \
- ${PYTHON_PKGNAMEPREFIX}marshmallow>0:devel/py-marshmallow@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \
+ ${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml@${PY_FLAVOR}
- ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR}
# tests_require = prance[osv]>=0.11
+TEST_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}openapi-spec-validator>0:devel/py-openapi-spec-validator@${PY_FLAVOR} \
+ ${PYTHON_PKGNAMEPREFIX}prance>=0.11:devel/py-prance@${PY_FLAVOR}
-TEST_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}prance>=0.11:devel/py-prance@${PY_FLAVOR} \
- ${PYTHON_PKGNAMEPREFIX}openapi-spec-validator>0:devel/py-openapi-spec-validator@${PY_FLAVOR}
Created attachment 228617 [details]
apispec.diff
I didn't know portfmt even exists. Such a great too, thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c00e76d78d04e08042d8aff5e644362aad13d701 commit c00e76d78d04e08042d8aff5e644362aad13d701 Author: Goran Mekić <meka@tilda.center> AuthorDate: 2021-10-12 08:21:30 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-10-12 08:25:47 +0000 devel/py-apispec: Update to 5.1.1 ChangeLog: https://github.com/marshmallow-code/apispec/blob/5.1.1/CHANGELOG.rst PR: 259061 devel/py-apispec/Makefile | 12 ++++++------ devel/py-apispec/distinfo | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) Hello Goran, portlint, portclippy and portfmt are just helpers tools that we should do not follow blindly. They are great at simple things like put some order in Makefile blocks, alphabetical order in some variables lists, etc. Sometimes they help, other times we need a personal look into it. Committed thanks! Cheers |
Created attachment 228578 [details] apispec.diff QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.0, amd64 tested) * maketest: OK (518 passed)