Bug 259082

Summary: science/py-tensorflow: fix build on powerpc64
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Piotr Kubaj <pkubaj>
Status: Closed FIXED    
Severity: Affects Some People CC: amzo1337, powerpc
Priority: --- Flags: bugzilla: maintainer-feedback? (amzo1337)
koobs: merge-quarterly?
Version: Latest   
Hardware: powerpc   
OS: Any   
Attachments:
Description Flags
patch koobs: maintainer-approval+

Description Piotr Kubaj freebsd_committer freebsd_triage 2021-10-11 21:23:13 UTC
Created attachment 228600 [details]
patch

The bundled abseil requires patching to build on powerpc64. This patch has already been upstreamed, but tensorflow uses an old version of abseil.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-12 04:09:07 UTC
Comment on attachment 228600 [details]
patch

Fetch, patch, configure, build, runtime and packaging fixes are:

Approved by: portmgr (blanket: <target> fix)
MFH: <branch>
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2021-10-12 10:35:00 UTC
It probably doesn't need to be MFH'd. My patch doesn't completely fix build, it now fails the same way as on amd64.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-10-12 19:07:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3ab9cf93726f7219c60161b8da3d091704093da

commit b3ab9cf93726f7219c60161b8da3d091704093da
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2021-10-12 18:37:07 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2021-10-12 18:37:07 +0000

    science/py-tensorflow: fix build on powerpc64

    The bundled abseil needs the same patch that was already upstreamed.

    Approved by: portmgr (blanket: build fix)
    PR:     259082

 science/py-tensorflow/Makefile                     |  3 +-
 ...-absl_base_internal_unscaledcycleclock.cc (new) | 47 ++++++++++++++++++++++
 .../files/patch-tensorflow_workspace.bzl           | 12 +++++-
 3 files changed, 59 insertions(+), 3 deletions(-)
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2021-10-12 20:46:57 UTC
Committed, thanks!