Bug 259170

Summary: audio/mixxx: should not set DOPTIMIZE:STRING=native
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy
Priority: --- Flags: bugzilla: maintainer-feedback? (acm)
Version: Latest   
Hardware: Any   
OS: Any   

Description Mikael Urankar freebsd_committer freebsd_triage 2021-10-14 16:20:33 UTC
march=native isn't valid on several non x86 platforms and causes build failures.

--- a/audio/mixxx/Makefile
+++ b/audio/mixxx/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=      mixxx
 DISTVERSION=   2.3.0
-PORTREVISION=  3
+PORTREVISION=  4
 CATEGORIES=    audio
 
 MAINTAINER=    acm@FreeBSD.org
@@ -47,7 +47,6 @@ USE_QT=               buildtools concurrent core dbus gui linguisttools_build network \
 CONFLICTS=     mixxx22*
 
 CMAKE_ARGS+=   -DINSTALL_USER_UDEV_RULES:BOOL=OFF \
-               -DOPTIMIZE:STRING=native \
                -DBATTERY:BOOL=OFF \
                -DFAAD:BOOL=OFF \
                -DMODPLUG:BOOL=ON \
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-10-14 21:04:58 UTC
It will also potentially break on x86 devices as it may enable hardware instructions based on build host that may not be available on target host.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-11-02 15:42:47 UTC
Alternative fix committed by pkubaj@ in commit 09e8de05c7b5230f7dfbc22f985ec39359be3780

Reference: https://cgit.freebsd.org/ports/commit/?id=09e8de05c7b5230f7dfbc22f985ec39359be3780