Bug 259179

Summary: biology/treekin: Mark as BROKEN
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: jwb
Priority: --- Flags: bugzilla: maintainer-feedback? (yuri)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/Reference-LAPACK/lapack/issues/604
Attachments:
Description Flags
Patch for treekin none

Description Daniel Engberg freebsd_committer freebsd_triage 2021-10-15 06:28:42 UTC 
Created attachment 228710 [details]
Patch for treekin

Fails on "error: too few arguments to function call"
Given that it has done this for months on the package builders perhaps its time to remove the port?

Reference:
https://portsfallout.com/fallout?port=biology%2Ftreekin%24&page=1
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-10-15 07:06:26 UTC 
Lapack changed their function declarations leaving software relying on changed functions, like treekin, broken.

I asked them how to patch the functions.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-10-15 08:35:02 UTC 
Thanks for looking into this
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-10-15 15:50:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c16b145a0f292e0aaf321c7b48681ccd63f7280b

commit c16b145a0f292e0aaf321c7b48681ccd63f7280b
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-10-15 15:47:33 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-10-15 15:50:24 +0000

    biology/treekin: Unbreak

    Recent Lapack API changes broke it.

    PR:             259179

 biology/treekin/files/patch-src_calcpp.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2021-10-15 15:50:50 UTC 
The port is now fixed.
Comment 5 Jason W. Bacon freebsd_committer freebsd_triage 2021-10-15 17:34:29 UTC 
Thanks, gents.

FYI, the definition is "unmaintained" has to be a bit more lax for scientific software.  It's not uncommon for software to go years without updates while still being in mainstream use.  Scientist-developers get wrapped up in other things and often there are no viable alternatives to the software.

So I wouldn't be too quick to remove scientific ports because a bug has persisted for months.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2021-10-15 18:03:07 UTC 
(In reply to Jason W. Bacon from comment #5)

I wholeheartedly agree.
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-11-07 01:34:56 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=95cd93086e6fb0a44865d86a95486dfa59c16a83

commit 95cd93086e6fb0a44865d86a95486dfa59c16a83
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-10-15 15:47:33 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-11-07 01:34:50 +0000

    biology/treekin: Unbreak

    Recent Lapack API changes broke it.

    PR:             259179
    (cherry picked from commit c16b145a0f292e0aaf321c7b48681ccd63f7280b)

 biology/treekin/files/patch-src_calcpp.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)