|Summary:||math/librsb: prevents package building, but doesn't optimize for local machine|
|Product:||Ports & Packages||Reporter:||Felix Palmen <felix>|
|Component:||Individual Port(s)||Assignee:||Stephen Montgomery-Smith <stephen>|
|Severity:||Affects Only Me||Flags:||bugzilla:
Description Felix Palmen 2021-10-16 07:50:15 UTC
Created attachment 228740 [details] 0001-math-librsb-add-OPTIMIZE-option Upstream's configure.ac contains a lot of logic to enable builds optimized for the local machine, but it seems this only happens when a hardcoded variable is changed from 'no' to 'yes'. Therefore, I suggest to add a port option enabling this and remove the restriction for package building. The attached patch also makes sure to pass CFLAGS to the configure script in a way that allows it to combine them with upstream's CFLAGS. I also found the distfile on all SF mirrors is slightly larger than the one expected in distinfo. As I don't have the old distfile, I can't check whether this is actually legit.
Comment 1 commit-hook 2021-10-16 10:23:44 UTC
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8c134c7c6596ff60940e9f478fe512fcef595e38 commit 8c134c7c6596ff60940e9f478fe512fcef595e38 Author: Stephen Montgomery-Smith <stephen@FreeBSD.org> AuthorDate: 2021-10-16 10:18:49 +0000 Commit: Stephen Montgomery-Smith <stephen@FreeBSD.org> CommitDate: 2021-10-16 10:18:49 +0000 math/librsb: Allow package building, add option for local optimization. Also update distinfo, and bump portrevision. PR: 259200 Reported by: Felix Palmen <firstname.lastname@example.org> math/librsb/Makefile | 12 +++++++++--- math/librsb/distinfo | 6 +++--- 2 files changed, 12 insertions(+), 6 deletions(-)
Comment 2 Stephen Montgomery-Smith 2021-10-16 10:24:15 UTC
Committed. Thank you very much for this bug report.