Bug 259254

Summary: [exp-run] without lorder(1)
Product: Ports & Packages Reporter: Ed Maste <emaste>
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: New ---    
Severity: Affects Only Me CC: bland, fullermd, lwhsu
Priority: --- Flags: lwhsu: exp-run?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
disconnect lorder from the build
none
remove use of lorder from converters/iconv none

Description Ed Maste freebsd_committer 2021-10-18 20:33:42 UTC
Created attachment 228812 [details]
disconnect lorder from the build

lorder serves no purpose on contemporary FreeBSD and may be removed in the future. Let's see if any ports make use of it.
Comment 2 Ed Maste freebsd_committer 2021-10-21 18:21:44 UTC
Created attachment 228928 [details]
remove use of lorder from converters/iconv
Comment 3 Ed Maste freebsd_committer 2021-10-21 18:23:22 UTC
converters/iconv review: https://reviews.freebsd.org/D32593
bland@ does not seem to have a Phabricator account, so attaching patch here.
Comment 4 commit-hook freebsd_committer 2021-12-20 18:05:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3e01ee76f2042fe07ad5cf8edeb5065bc0aba320

commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-12-20 17:57:34 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-12-20 17:59:01 +0000

    lorder: add note that it is no longer required

    Use of lorder(1) is not required by contemporary linkers.

    The GNU coreutils manual[1] has a good description of the use of lorder
    and tsort:

        This whole procedure has been obsolete since about 1980, because
        Unix archives now contain a symbol table (traditionally built by
        ranlib, now generally built by ar itself), and the Unix linker uses
        the symbol table to effectively make multiple passes over an archive
        file.

    See 0e1e341b486c for some more details.

    [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html

    PR:             259254 [exp-run]
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation

 usr.bin/lorder/lorder.1 | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 5 Ed Maste freebsd_committer 2021-12-20 18:08:55 UTC
CC marius@ for cdrdao, fullermd@over-yonder.net for libcidr, and uqs@ for sysutils/symon
Comment 6 commit-hook freebsd_committer 2021-12-20 20:54:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0a6f1823129e631da6f11368836f8b2fd5483096

commit 0a6f1823129e631da6f11368836f8b2fd5483096
Author:     Marius Strobl <marius@FreeBSD.org>
AuthorDate: 2021-12-20 20:36:30 +0000
Commit:     Marius Strobl <marius@FreeBSD.org>
CommitDate: 2021-12-20 20:52:44 +0000

    sysutils/cdrdao: drop use of lorder(1)

    While at it, switch pkg-plist to @postunexec and remove remnants of the
    gcdmaster slave missed in db5b4a8694f902fef50919c2744ee2ee31fcd89b.

    PR:     259254

 sysutils/cdrdao/Makefile                           | 15 +++++-------
 sysutils/cdrdao/files/patch-dao_cdrdao.man         | 27 +++++++++++++++-------
 .../files/patch-scsilib_RULES_i386-freebsd-cc.rul  |  8 ++++---
 sysutils/cdrdao/pkg-plist                          |  2 +-
 4 files changed, 31 insertions(+), 21 deletions(-)
Comment 7 Marius Strobl freebsd_committer 2021-12-20 21:00:04 UTC
I'm done here.
Comment 8 commit-hook freebsd_committer 2021-12-27 09:28:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=128d3b57be1f406be9656f40152c2290494da1b9

commit 128d3b57be1f406be9656f40152c2290494da1b9
Author:     Ulrich Spörlein <uqs@FreeBSD.org>
AuthorDate: 2021-12-27 09:24:00 +0000
Commit:     Ulrich Spörlein <uqs@FreeBSD.org>
CommitDate: 2021-12-27 09:27:43 +0000

    sysutils/symon: Update to 2.88

    This version only changes some Linux specific area. Get rid of the
    calls to lorder and tsort though, as these will go away.

    PR:             259254

 sysutils/symon/Makefile | 6 +++---
 sysutils/symon/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 9 commit-hook freebsd_committer 2022-01-03 01:17:53 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b498248f7a705d45cab6ac14ec67bb408621aabf

commit b498248f7a705d45cab6ac14ec67bb408621aabf
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-12-20 17:57:34 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-01-03 01:17:00 +0000

    lorder: add note that it is no longer required

    Use of lorder(1) is not required by contemporary linkers.

    The GNU coreutils manual[1] has a good description of the use of lorder
    and tsort:

        This whole procedure has been obsolete since about 1980, because
        Unix archives now contain a symbol table (traditionally built by
        ranlib, now generally built by ar itself), and the Unix linker uses
        the symbol table to effectively make multiple passes over an archive
        file.

    See 0e1e341b486c for some more details.

    [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html

    PR:             259254 [exp-run]
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320)

 usr.bin/lorder/lorder.1 | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 10 commit-hook freebsd_committer 2022-01-03 01:18:54 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=811f36c660a2d40b57bfbf8a9728866d83130d12

commit 811f36c660a2d40b57bfbf8a9728866d83130d12
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-12-20 17:57:34 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-01-03 01:17:34 +0000

    lorder: add note that it is no longer required

    Use of lorder(1) is not required by contemporary linkers.

    The GNU coreutils manual[1] has a good description of the use of lorder
    and tsort:

        This whole procedure has been obsolete since about 1980, because
        Unix archives now contain a symbol table (traditionally built by
        ranlib, now generally built by ar itself), and the Unix linker uses
        the symbol table to effectively make multiple passes over an archive
        file.

    See 0e1e341b486c for some more details.

    [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html

    PR:             259254 [exp-run]
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320)

 usr.bin/lorder/lorder.1 | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)