Summary: | devel/py-setuptools_scm: Needs to be updated to 5.x to get a successful build of py-platformdirs | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Bob Frazier <bobf> | ||||
Component: | Individual Port(s) | Assignee: | Kai Knoblich <kai> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | kai, rhurlin, sunpoet | ||||
Priority: | --- | Flags: | kai:
merge-quarterly+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://github.com/pypa/setuptools_scm/blob/v5.0.2/CHANGELOG.rst | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 259381 | ||||||
Attachments: |
|
Description
Bob Frazier
2021-10-24 21:05:09 UTC
Created attachment 229020 [details] py-setuptools_scm-5.0.2.patch (In reply to Bob Frazier from comment #0) Hi Bob, thank you for the report and the info! At the outset: Can you please try the attached patch? It updates devel/py-setuptools_scm to 5.0.2 and should fix the issue with devel/py-platformdirs. More detailed info: The devel/py-platformdirs port has "setuptools_scm[toml]>=5" in its "pyproject.toml" (see also bug #259381, comment #2) thus it requires a newer version of devel/py-setuptools_scm which is still at 4.1.2_3. Regarding the test suite: > =================================== 1 failed, 112 passed, 34 skipped, 1 xfailed in 15.71 seconds =================================== > *** Error code 1 Only one test failed and that one might be a "red herring". I'm able to run the test suite without any problems. (In reply to Kai Knoblich from comment #1) yes! this patch was perfect (thank you) totem build proceeding as expected (hopefully nothing else to deal with) totem completed building. all good now as far as I can tell. hopefully the update to py-setuptools_scm version 5+ did not break anything else and fixed everything else at the same time. (In reply to Bob Frazier from comment #3) Thank you for the quick feedback, it's nice to hear, that the devel/py-setuptools_scm v5.0.2 update solved the issue. I'll do some more QA work and if everything works out, devel/py-setuptools_scm 5.0.2 should be committed in 1-2 days from now on in the main branch. I plan to do a MFH to the 2021Q4 branch as well. Please don't hesitate to contact me if you should still find a problem with devel/py-setuptools_scm. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=33a4a1d205bd4323d330b7cc5f39925e5b3e811c commit 33a4a1d205bd4323d330b7cc5f39925e5b3e811c Author: Kai Knoblich <kai@FreeBSD.org> AuthorDate: 2021-10-26 10:08:35 +0000 Commit: Kai Knoblich <kai@FreeBSD.org> CommitDate: 2021-10-26 10:08:35 +0000 devel/py-setuptools_scm: Update to 5.0.2 * Use this release as an intermediate step before the port is updated to the 6.x release, because it contains mostly bugfixes and is also required for the 2021Q4 branch. The latter is necessary in order to be able to build certain ports successfully if devel/py-setuptools_scm is already present in the build environment. For instance, devel/py-platformdirs, which can be built without it but if devel/py-setuptools is already installed, it requires the 5.x release of it for build. [1] * Also adjust the description of the TOML option slightly with an appropriate warning to avoid build issues related to parsing "pyproject.toml" files during setup. [2] Changelog since 4.1.2: https://github.com/pypa/setuptools_scm/blob/v5.0.2/CHANGELOG.rst PR: 259381 [2], 259420 (both related) MFH: 2021Q4 (after 1 week) [1] devel/py-setuptools_scm/Makefile | 5 ++--- devel/py-setuptools_scm/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) Committed, devel/py-setuptools_scm is now at 5.0.2 in the main branch, pending MFH to 2021Q4. A commit in branch 2021Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5bfd0738fbe861b2a371801dbe7f12daf5d93f33 commit 5bfd0738fbe861b2a371801dbe7f12daf5d93f33 Author: Kai Knoblich <kai@FreeBSD.org> AuthorDate: 2021-10-26 10:08:35 +0000 Commit: Kai Knoblich <kai@FreeBSD.org> CommitDate: 2021-11-02 11:53:57 +0000 devel/py-setuptools_scm: Update to 5.0.2 * Use this release as an intermediate step before the port is updated to the 6.x release, because it contains mostly bugfixes and is also required for the 2021Q4 branch. The latter is necessary in order to be able to build certain ports successfully if devel/py-setuptools_scm is already present in the build environment. For instance, devel/py-platformdirs, which can be built without it but if devel/py-setuptools is already installed, it requires the 5.x release of it for build. [1] * Also adjust the description of the TOML option slightly with an appropriate warning to avoid build issues related to parsing "pyproject.toml" files during setup. [2] Changelog since 4.1.2: https://github.com/pypa/setuptools_scm/blob/v5.0.2/CHANGELOG.rst PR: 259381 [2], 259420 (both related) MFH: 2021Q4 (after 1 week) [1] (cherry picked from commit 33a4a1d205bd4323d330b7cc5f39925e5b3e811c) devel/py-setuptools_scm/Makefile | 5 ++--- devel/py-setuptools_scm/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) Committed to the 2021Q4 branch, all done! Thank you, Bob, for reporting the issue and the quick feedback! |