Bug 259499

Summary: games/stonesoup: Fix build on armv6/armv7, Remove DOCS option
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Many People CC: mikael
Priority: --- Keywords: easy
Version: LatestFlags: fuz: merge-quarterly?
Hardware: arm   
OS: Any   
Bug Depends on:    
Bug Blocks: 259509    
Attachments:
Description Flags
games/stonesoup: fix build on armv6/armv7 fuz: maintainer-approval+

Description Robert Clausecker freebsd_committer freebsd_triage 2021-10-28 10:45:38 UTC
Created attachment 229092 [details]
games/stonesoup: fix build on armv6/armv7

Fix build on armv6/armv7 by removing a misguided OS-detection case.
Fix build with WRKDIR inside a git-maintained ports tree.
Turn the custom README into a pkg-message for better visibility.
Take over maintainership of this unmaintained port.

Please MFH if possible.

I will provide an update to the current version in a separate PR.

Tested with Poudriere on armv7 arm64 i386 amd64 FreeBSD 13.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2021-11-07 00:04:54 UTC
Note that this change set also removes the DOCS option.  It used to control whether the README was shipped, but that's no longer needed with the README gone.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-11-08 07:43:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5304a1914e4dfa3da4cb6d54932ff2f0d5e32f89

commit 5304a1914e4dfa3da4cb6d54932ff2f0d5e32f89
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-28 10:39:35 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-11-08 07:41:55 +0000

    games/stonesoup: Fix build on armv6/armv7.

    Fix build on armv6/armv7 by removing a misguided OS-detection case.
    Fix build with WRKDIR inside a git-maintained ports tree.
    Turn the custom README into a pkg-message for better visibility.
    Take over maintainership of this unmaintained port.

    PR:             259499

 games/stonesoup/Makefile                           | 15 ++++-----------
 games/stonesoup/files/README.FreeBSD.in (gone)     |  7 -------
 games/stonesoup/files/patch-platform.h (new)       | 16 ++++++++++++++++
 games/stonesoup/files/patch-util_gen__ver.pl (new) | 12 ++++++++++++
 games/stonesoup/files/pkg-message.in (new)         | 18 ++++++++++++++++++
 games/stonesoup/pkg-plist                          |  1 -
 6 files changed, 50 insertions(+), 19 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-08 11:56:58 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d2630fc659f13bc2b230852ee4fc95c50a2ae15

commit 7d2630fc659f13bc2b230852ee4fc95c50a2ae15
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-28 10:39:35 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-11-08 11:56:14 +0000

    games/stonesoup: Fix build on armv6/armv7.

    Fix build on armv6/armv7 by removing a misguided OS-detection case.
    Fix build with WRKDIR inside a git-maintained ports tree.
    Turn the custom README into a pkg-message for better visibility.
    Take over maintainership of this unmaintained port.

    PR:             259499
    (cherry picked from commit 5304a1914e4dfa3da4cb6d54932ff2f0d5e32f89)

 games/stonesoup/Makefile                           | 15 ++++-----------
 games/stonesoup/files/README.FreeBSD.in (gone)     |  7 -------
 games/stonesoup/files/patch-platform.h (new)       | 16 ++++++++++++++++
 games/stonesoup/files/patch-util_gen__ver.pl (new) | 12 ++++++++++++
 games/stonesoup/files/pkg-message.in (new)         | 18 ++++++++++++++++++
 games/stonesoup/pkg-plist                          |  1 -
 6 files changed, 50 insertions(+), 19 deletions(-)