Bug 259564
| Summary: | multimedia/x265: add option to use altivec on powerpc64 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | freebsd-2024, powerpc | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(freebsd-2024) |
||||||
| Version: | Latest | ||||||||
| Hardware: | powerpc | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 229159 [details]
v2
Actually don't enable it by default, will break users of older POWER.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cc29ad6598478ba1125b88114d88838f86a6b8be commit cc29ad6598478ba1125b88114d88838f86a6b8be Author: Piotr Kubaj <pkubaj@FreeBSD.org> AuthorDate: 2021-11-16 14:44:19 +0000 Commit: Piotr Kubaj <pkubaj@FreeBSD.org> CommitDate: 2021-11-16 14:44:19 +0000 multimedia/x265: add option to use altivec on powerpc64 PR: 259564 Approved by: mi@ALDAN.algebra.com (maintainer timeout) multimedia/x265/Makefile | 42 +++++++++++++++++++++-- multimedia/x265/files/patch-source_CMakeLists.txt | 20 ++++++++--- 2 files changed, 55 insertions(+), 7 deletions(-) |
Created attachment 229158 [details] patch This patch uses the ASM option to simplify things, but actually assembly isn't used, just SIMD code in C/C++. Anyway, POWER8 intrinsics for x265 are available for HI8P, HI10P and HI12P, but additional AltiVec code is only available for HI8P. On top of that, using ENABLE_ASSEMBLY actually breaks build (because there's no assembly, but C/C++ code). Also, remove ASM_PREVENTS*. It doesn't work after including bsd.port.options.mk.