Summary: | mail/mls: Fix build on FreeBSD 13/14, Level up ports compliance | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Robert Clausecker <fuz> | ||||
Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | diizzy, otis, swills | ||||
Priority: | --- | Keywords: | needs-patch, needs-qa | ||||
Version: | Latest | Flags: | fuz:
merge-quarterly?
|
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
http://marki.host.sk/MLS/ in MASTER_SITES is dead Given that it hasn't been touched in 15+ years does it actually work as intended? The PHP part on the site at least errors out ( http://www.marki-online.net/MLS/demo/mls.php ) and I would guess that it's also the same in the package (In reply to Daniel Engberg from comment #1) Hi Daniel, I can confirm that the port still works and produces mail statistics just fine. As for the PHP part, I have not and cannot test it. Feel free to test it yourself if you like. If you commit this change, feel free to leave the dead MASTER_SITES entry out. otis@ has informed upstream about the -fno-common related errors. Upstream may release a new version to fix these. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=342a19d2da54e08fc124722bf9d91b75303582df commit 342a19d2da54e08fc124722bf9d91b75303582df Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-02-09 15:20:28 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-14 20:18:57 +0000 mail/mls: improve and unbreak with -fno-common - liberally sprinkle extern all over the place - define LICENSE - take over maintainership of this unmaintained port - ship examples and html files - define DOCS and EXAMPLES options - pacify portlint and portclippy - add a pkg-message as the author intended - remove dead MASTER_SITES entry PR: 259586 Approved by: flo (mentor) Differential Revision: https://reviews.freebsd.org/D38516 mail/mls/Makefile | 38 +++++++++++++++++++++++++++------- mail/mls/distinfo | 1 + mail/mls/files/patch-Makefile | 7 +++---- mail/mls/files/patch-mls.c (new) | 19 +++++++++++++++++ mail/mls/files/patch-mls.h | 13 ++++++++++-- mail/mls/files/patch-mls__mime.h (new) | 11 ++++++++++ mail/mls/files/patch-mls_text.c | 4 ++-- mail/mls/files/patch-mls_text.h | 6 +++--- mail/mls/files/pkg-message.in (new) | 6 ++++++ 9 files changed, 86 insertions(+), 19 deletions(-) |
Created attachment 229185 [details] mail/mls: improve and unbreak with -fno-common mail/mls: improve and unbreak with -fno-common - liberally sprinkle extern all over the place - define LICENSE - take over maintainership of this unmaintained port - ship examples and html files - define DOCS and EXAMPLES options - pacify portlint - add a pkg-message as the author intended Tested with Poudriere on armv7 arm64 FreeBSD 13. Please MFH if possible.